Add job running into completion in ID Localization. #16705

irvifa · 2019-10-05T20:43:34Z

This address #15341 and jk8s/sig-docs-id#17

irvifa · 2019-10-05T20:43:44Z

/cc @kubernetes/sig-docs-id-reviews

irvifa · 2019-10-05T20:43:51Z

/assign

netlify · 2019-10-05T20:51:38Z

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 301e9bd

https://deploy-preview-16705--kubernetes-io-master-staging.netlify.com

irvifa · 2019-10-05T21:25:48Z

Related to jk8s/sig-docs-id#14

content/id/docs/concepts/workloads/controllers/jobs-run-to-completion.md

girikuncoro · 2019-10-12T18:23:54Z

/assign

irvifa · 2019-10-12T19:11:31Z

@girikuncoro can you please review this PR? Before I trim the white spaces

girikuncoro

Great work on translating this page! 🎉 Learning from previous reviews that crashes Github, I'm dividing my reviews into 2 parts.

content/id/docs/concepts/workloads/controllers/jobs-run-to-completion.md

girikuncoro · 2019-10-13T00:54:35Z

content/id/docs/concepts/workloads/controllers/jobs-run-to-completion.md

+
+Sebuah Pod juga dapat gagal secara menyeluruh, untuk beberapa alasan yang mungkin, misalnya saja, 
+ketika Pod tersebut dipindahkan dari node (ketika node di-upgrade, di-restart, dihapus, dsb.), atau 
+jika sebuah container dalam Pod gagal dan `.spec.template.spec.restartPolicy = "Never"`. Ketika 


container should be Container

girikuncoro · 2019-10-13T00:54:46Z

content/id/docs/concepts/workloads/controllers/jobs-run-to-completion.md

+Sebuah Pod juga dapat gagal secara menyeluruh, untuk beberapa alasan yang mungkin, misalnya saja, 
+ketika Pod tersebut dipindahkan dari node (ketika node di-upgrade, di-restart, dihapus, dsb.), atau 
+jika sebuah container dalam Pod gagal dan `.spec.template.spec.restartPolicy = "Never"`. Ketika 
+sebuah Pod gagal, maka kontroler Job akan membuat sebuah Pod baru. Ini berarti aplikasi kamu haruslah 


change kontroler to controller since kontroler is not indonesian word

content/id/docs/concepts/workloads/controllers/jobs-run-to-completion.md

girikuncoro

This is the remaining reviews, great work! Mostly comments are related to typo, styling, and some wordings. There are some missing english translation as well and some remaining english sentence that should be removed. Also, please don't close the comments once you have addressed them (don't click on "resolve comment"), so that reviewers can easily see and verify

girikuncoro · 2019-10-13T00:58:03Z

content/id/docs/concepts/workloads/controllers/jobs-run-to-completion.md

+maka bisa saja terdapat keadaan dimana terdapat multipel Pod yang dijalankan pada waktu yang sama. 
+Dengan demikian, Pod kamu haruslah fleksibel terhadap adanya konkurensi.
+
+### _Policy_ _Backoff_ apabila Terjadi Kegagalan


how about kebijakan or mekanisme, instead of Policy?

girikuncoro · 2019-10-13T00:58:28Z

content/id/docs/concepts/workloads/controllers/jobs-run-to-completion.md

+dsb. Untuk melakukan hal tersebut, spesifikasikan `.spec.backoffLimit` dengan nilai _retry_ yang diinginkan 
+sebelum menerjemahkan Job dalam keadaan gagal. Secara default, nilai dari _field_ tersebut adalah 6.
+Pod yang gagal dijalankan dan terkait dengan suatu Job tertentu akan dibuat kembali oleh 
+kontroler Job dengan _delay_ _back-off_ eksponensial (10 detik, 20 detik, 40 detik ...) 


change kontroler to controller since kontroler is not indonesian word

content/id/docs/concepts/workloads/controllers/jobs-run-to-completion.md

girikuncoro · 2019-10-13T01:10:33Z

content/id/docs/concepts/workloads/controllers/jobs-run-to-completion.md

+default pada _field_ ini ketika Job dibuat. Sistem akan memilih nilai dari selektor yang ada 
+dan memastikan nilainya tidak akan beririsan dengan Job lainnya.
+
+Meskipun demikian, ipada beberapa kasus, kamu bisa saja memiliki kebutuhan untuk meng-_override_ 


typo

Suggested change

Meskipun demikian, ipada beberapa kasus, kamu bisa saja memiliki kebutuhan untuk meng-_override_

Meskipun demikian, pada beberapa kasus, kamu bisa saja memiliki kebutuhan untuk meng-_override_

girikuncoro · 2019-10-13T01:11:04Z

content/id/docs/concepts/workloads/controllers/jobs-run-to-completion.md

+terkait dengan Job tadi, maka Pod dari Job yang tidak terkait dengan Job tadi akna dihapus, atau Job ini 
+akan menghitung _completion_ dari Pod lain sebagai tolak ukur suksesnya Job tersebut, atau bisa saja salah satu 
+atau kedua Job tidak dapat membuat Pod baru yang digunakan untuk menyelesaikan Job tersebut. 
+Jika selektor yang tidak unik dipilih, maka kontroler lain (misalnya ReplicationController) dan Pod 


change kontroler to controller since kontroler is not indonesian word

content/id/docs/concepts/workloads/controllers/jobs-run-to-completion.md

girikuncoro

This is the remaining reviews, great work! Mostly comments are related to typo, styling, and some wordings. There are some missing english translation as well and some remaining english sentence that should be removed. Also, please don't close the comments once you have addressed them (don't click on "resolve comment"), so that reviewers can easily see and verify

girikuncoro

This is the last piece of my review comments

content/id/docs/concepts/workloads/controllers/jobs-run-to-completion.md

girikuncoro · 2019-10-21T05:20:38Z

@irvifa any update on this?

irvifa · 2019-11-04T14:08:23Z

@girikuncoro updated 🙇

girikuncoro · 2019-12-05T04:38:51Z

@irvifa looking great, thanks for your continuous contribution to kubernetes docs and community! 🎉

/lgtm
/approve

k8s-ci-robot · 2019-12-05T04:39:10Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: girikuncoro

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~content/id/OWNERS~~ [girikuncoro]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

* Fix a command in kubectl cheatsheet (kubernetes#17888) * Remove dead links to old getting started guides (kubernetes#17889) * Change PowerShell example to use the -Raw flag (kubernetes#17645) * Spelling correction (kubernetes#17895) * fix some broken links (kubernetes#17897) * update exmaple for job (kubernetes#17903) * Deleted duplicate sentence and corrected typo (kubernetes#17902) * Corrected the typo of 'chck' with 'check' * Removed the duplicate sentence * Fix a dead link (kubernetes#17900) * fix 404 urls in kustomization.md (kubernetes#17793) * Update kustomization.md fix 404 urls in kustomization.md * Update content/en/docs/tasks/manage-kubernetes-objects/kustomization.md Co-Authored-By: Tim Bannister <[email protected]> * update kustomization.md to be more stable * Fix broken link to AWS provider settings source (kubernetes#17899) * update style guide for styling component names (kubernetes#17588) * update style guide for styling component names - Attempt to outline style conventions for components and component tools - Interested in comments and feedback * update style examples * style edits - removed code style for components not cmd tools - added style suggestion for namespaces - cleaned up a few stray spaces * fix output example in automated-tasks-with-cron-jobs.md (kubernetes#17906) * Update an out-of-date link (kubernetes#17907) Signed-off-by: umiblue <[email protected]> * en-fr: Append Note To Alternative Linux Install (kubernetes#17827) * Blog post: Gardener Project Update (kubernetes#17516) * Add Gardener Project Update blog post * Update and rename 2019-11-10-gardener-project-update.md to 2019-11-27-gardener-project-update.md * Update and rename 2019-11-27-gardener-project-update.md to 2019-12-02-gardener-project-update.md * Update KubeCon buttons for Shanghai (kubernetes#17916) * fix path not consistent (kubernetes#17923) * updated 3 logos on case studies page (kubernetes#17628) * Update kube-scheduler.md (kubernetes#17283) Fix grammar typo * Add missing `systemctl` step for running `cri-o` (kubernetes#17926) After installing `cri-o`, we must run `systemctl daemon-reload` before trying to run `systemctl start crio`. Otherwise, `systemd` doesn't know about the crio configuration. Similar instructions already exist for installing docker - this diff adds these instructions for crio. * add cidr to glossary (kubernetes#17550) * add CIDR * modify cidr definition * Update content/en/docs/reference/glossary/cidr.md Co-Authored-By: Chris <[email protected]> * Update content/en/docs/reference/glossary/cidr.md Co-Authored-By: Chris <[email protected]> * specify components requiring feature gate (kubernetes#17922) * specify components requiring feature gate currently, TTLafterfinished feature gate is a flag that can be passed to kube-apiserver, kube-scheduler and kube-controller-manager. The current description doesn't state what components to pass the flag to. * specify components requiring feature gate * Fixed hot reload panic of local hugo issue. (kubernetes#17894) * fix-up 404 urls (kubernetes#17936) * fix-up 404 urls * Revert "fix-up 404 urls" This reverts commit 4515c4d. * fix-ip 404 urls * fix-up 404 urls * Update guaranteed-scheduling-critical-addon-pods.md (kubernetes#17151) * Update guaranteed-scheduling-critical-addon-pods.md cleanup old stuff again * Update content/en/docs/tasks/administer-cluster/guaranteed-scheduling-critical-addon-pods.md Co-Authored-By: Tim Bannister <[email protected]> * Update guaranteed-scheduling-critical-addon-pods.md remove whitespace * correct diagram label (kubernetes#17942) * fix-up 404 urls (kubernetes#17941) * fix-up 404 urls * Revert "fix-up 404 urls" This reverts commit 4515c4d. * fix-ip 404 urls * fix-up 404 urls * fix-up 404 urls Revert "fix-up 404 urls" This reverts commit 4515c4d. fix-ip 404 urls fix-up 404 urls * fix-up 404 urls * Translate Minikube environment to French (kubernetes#17939) * Freshen the list of English content approvers for SIG Docs (kubernetes#17929) * Add YouTube social button in header and footer (kubernetes#16838) * Update the cluster create and disable commands (kubernetes#17947) * Initialize DNS Pod Service for ID Localization. (kubernetes#16707) Co-Authored-By: Giri Kuncoro <[email protected]> Co-Authored-By: Tim Bannister <[email protected]> * Add statefulsets for ID localization. (kubernetes#16700) * Initialize Common Label for ID Localization. (kubernetes#16706) * Add job running into completion in ID Localization. (kubernetes#16705) * Updated kubeone URL (kubernetes#17766)

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 5, 2019

k8s-ci-robot added language/id Issues or PRs related to Indonesian language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Oct 5, 2019

k8s-ci-robot assigned irvifa Oct 5, 2019

k8s-ci-robot requested review from girikuncoro and Rajakavitha1 October 5, 2019 20:44

irvifa requested review from qbl and danninov and removed request for Rajakavitha1 October 5, 2019 20:45

irvifa requested a review from phanama October 6, 2019 09:29

girikuncoro mentioned this pull request Oct 7, 2019

Tracking Indonesian Translation Progress (M2) #15341

Closed

45 tasks

joshuabezaleel reviewed Oct 7, 2019

View reviewed changes

content/id/docs/concepts/workloads/controllers/jobs-run-to-completion.md Outdated Show resolved Hide resolved

k8s-ci-robot assigned girikuncoro Oct 12, 2019

girikuncoro reviewed Oct 13, 2019

View reviewed changes

girikuncoro requested changes Oct 13, 2019

View reviewed changes

irvifa force-pushed the id/jobs-run-to-completion branch from 42f0cb0 to 78c58a5 Compare November 4, 2019 14:06

Add job running into completion in ID Localization.

301e9bd

irvifa force-pushed the id/jobs-run-to-completion branch from 78c58a5 to 301e9bd Compare November 4, 2019 14:07

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 5, 2019

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 5, 2019

k8s-ci-robot merged commit 80e5ceb into kubernetes:master Dec 5, 2019

zacharysarah pushed a commit to zacharysarah/website that referenced this pull request Dec 5, 2019

Add job running into completion in ID Localization. (kubernetes#16705)

e1aa7c3

zacharysarah pushed a commit to zacharysarah/website that referenced this pull request Dec 5, 2019

Add job running into completion in ID Localization. (kubernetes#16705)

69bb2b2

zacharysarah pushed a commit to zacharysarah/website that referenced this pull request Dec 5, 2019

Add job running into completion in ID Localization. (kubernetes#16705)

6c5c0a6

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add job running into completion in ID Localization. #16705

Add job running into completion in ID Localization. #16705

irvifa commented Oct 5, 2019

irvifa commented Oct 5, 2019

irvifa commented Oct 5, 2019

netlify bot commented Oct 5, 2019 •

edited

Loading

irvifa commented Oct 5, 2019

girikuncoro commented Oct 12, 2019

irvifa commented Oct 12, 2019

girikuncoro left a comment

girikuncoro Oct 13, 2019 •

edited

Loading

girikuncoro Oct 13, 2019 •

edited

Loading

girikuncoro left a comment

girikuncoro Oct 13, 2019

girikuncoro Oct 13, 2019

girikuncoro Oct 13, 2019

girikuncoro Oct 13, 2019

girikuncoro left a comment

girikuncoro left a comment

girikuncoro commented Oct 21, 2019

irvifa commented Nov 4, 2019

girikuncoro commented Dec 5, 2019

k8s-ci-robot commented Dec 5, 2019

	Meskipun demikian, ipada beberapa kasus, kamu bisa saja memiliki kebutuhan untuk meng-_override_
	Meskipun demikian, pada beberapa kasus, kamu bisa saja memiliki kebutuhan untuk meng-_override_

Add job running into completion in ID Localization. #16705

Add job running into completion in ID Localization. #16705

Conversation

irvifa commented Oct 5, 2019

irvifa commented Oct 5, 2019

irvifa commented Oct 5, 2019

netlify bot commented Oct 5, 2019 • edited Loading

irvifa commented Oct 5, 2019

girikuncoro commented Oct 12, 2019

irvifa commented Oct 12, 2019

girikuncoro left a comment

Choose a reason for hiding this comment

girikuncoro Oct 13, 2019 • edited Loading

Choose a reason for hiding this comment

girikuncoro Oct 13, 2019 • edited Loading

Choose a reason for hiding this comment

girikuncoro left a comment

Choose a reason for hiding this comment

girikuncoro Oct 13, 2019

Choose a reason for hiding this comment

girikuncoro Oct 13, 2019

Choose a reason for hiding this comment

girikuncoro Oct 13, 2019

Choose a reason for hiding this comment

girikuncoro Oct 13, 2019

Choose a reason for hiding this comment

girikuncoro left a comment

Choose a reason for hiding this comment

girikuncoro left a comment

Choose a reason for hiding this comment

girikuncoro commented Oct 21, 2019

irvifa commented Nov 4, 2019

girikuncoro commented Dec 5, 2019

k8s-ci-robot commented Dec 5, 2019

netlify bot commented Oct 5, 2019 •

edited

Loading

girikuncoro Oct 13, 2019 •

edited

Loading

girikuncoro Oct 13, 2019 •

edited

Loading