kubeadm: adds upgrade instructions for 1.13 #11138

chuckha · 2018-11-20T18:56:54Z

Signed-off-by: Chuck Ha [email protected]

/cc @neolit123 @rdodev @timothysc

Signed-off-by: Chuck Ha <[email protected]>

k8s-ci-robot · 2018-11-20T18:56:57Z

@chuckha: GitHub didn't allow me to request PR reviews from the following users: rdodev.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

Signed-off-by: Chuck Ha [email protected]

/cc @neolit123 @rdodev @timothysc

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8sio-netlify-preview-bot · 2018-11-20T18:56:58Z

Deploy preview for kubernetes-io-vnext-staging processing.

Built with commit b28cf21

https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/5bfd80fd0ff8d426079c8ace

chuckha · 2018-11-20T18:57:53Z

xrefs
#10937
kubernetes/kubeadm#1261

chuckha · 2018-11-20T19:01:59Z

/assign @Bradamant3

chuckha · 2018-11-20T19:02:25Z

/milestone 1.13

neolit123

thanks @chuckha
LGTM

neolit123 · 2018-11-20T19:05:49Z

/sig cluster-lifecycle
/priority critical-urgent

rdodev · 2018-11-20T19:10:44Z

I'm nowhere near with HA docs. I will split off, so that this can be merged.

neolit123 · 2018-11-20T19:11:21Z

/lgtm

tengqm · 2018-11-21T01:23:18Z

content/en/docs/tasks/administer-cluster/kubeadm/kubeadm-upgrade-1-13.md

+
+- You need to have a `kubeadm` Kubernetes cluster running version 1.12.0 or later.
+  [Swap must be disabled][swap].
+  The cluster should use a static control plane and etcd pods.


Not sure we have the term "static control plane" defined elsewhere. Consider a rewording please?

the end of the sentence reads static control plane and etcd pods so, it's the Pods that are static.
https://kubernetes.io/docs/tasks/administer-cluster/static-pod/

Oh I see. So it actually means 'static pods for control plane and etcd'. Thanks for pointing that out.

It's also part of the language of the upgrade docs at least since 1.10

tengqm · 2018-11-21T01:28:37Z

content/en/docs/tasks/administer-cluster/kubeadm/kubeadm-upgrade-1-13.md

+
+## Upgrade master and node packages
+
+1.  Prepare each node for maintenance, marking it unschedulable and evicting the workloads:


Suggested change

1. Prepare each node for maintenance, marking it unschedulable and evicting the workloads:

1. Prepare each node for maintenance, i.e. marking it unschedulable and evicting the workloads:

Please consider adding 'i.e.' to avoid misunderstandings like 'prepare node for maintenance' means some extra steps before marking the node unschedulable.

Raising a minor point: Shouldn't we avoid latin terms, such as i.e.? Can we use "that is" instead of it? :)

that's what the docs guide says.

tengqm · 2018-11-21T01:32:54Z

content/en/docs/tasks/administer-cluster/kubeadm/kubeadm-upgrade-1-13.md

+- Enforces the version skew policies.
+- Makes sure the control plane images are available or available to pull to the machine.
+- Upgrades the control plane components or rollbacks if any of them fails to come up.
+- Applies the new `kube-dns` and `kube-proxy` manifests and enforces that all necessary RBAC rules are created.


We can say "enforces that all necessary RBAC rules" or "ensures that all necessary RBAC rules are created", right?

Addressed a couple of copyedit comments a bit more cleanly.

Bradamant3 · 2018-11-27T17:39:13Z

/lgtm
/approve

k8s-ci-robot · 2018-11-27T17:39:21Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Bradamant3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~content/en/OWNERS~~ [Bradamant3]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

* kubeadm: adds upgrade instructions for 1.13 Signed-off-by: Chuck Ha <[email protected]> * add minor copyedits Addressed a couple of copyedit comments a bit more cleanly.

* Update metadata.generation behaviour for custom resources (#10705) * update docs promoting plugins to beta (#10796) * docs update to promote TaintBasedEvictions to beta (#10765) * First Korean l10n work for dev-1.13 (#10719) * Update outdated l10n(ko) contents (#10689) fixes #10686 * Translate concepts/overview/what-is-kubernetes in Korean (#10690) * Translate concepts/overview/what-is-kubernetes in Korean * Feedback from ClaudiaJKang * Translate concepts/overview/components in Korean (#10882) * Translate concepts/overview/components in Korean #10717 * Translate concepts/overview/components in Korean * Translate concepts/overview/components in Korean * Apply Korean glossary: 서비스 어카운트 * Translate concepts/overview/kubernetes-api in Korean (#10773) * Translate concepts/overview/kubernetes-api in Korean * Applied feedback from ianychoi * kubeadm: update the configuration docs to v1beta1 (#10959) * kubeadm: add small v1beta1 related updates (#10988) * ADD content/zh/docs/reference/setup-tools/kubeadm/kubeadm.md (#11031) * ADD content/zh/docs/reference/setup-tools/kubeadm/kubeadm.md * ADD content/zh/docs/reference/setup-tools/kubeadm/generated/kubeadm_init.md * Update content/zh/docs/reference/setup-tools/kubeadm/kubeadm.md Accepted Co-Authored-By: YouthLab <[email protected]> * do not change 'master' or 'worker' nodes to '主从' * Doc updates for volume scheduling GA (#10743) * Doc updates for volume scheduling GA * Make trivial change to kick build * Document nodelease feature (#10699) * advanced audit doc for ModeBlockingStrict (#10203) * Rename EncryptionConfig to EncryptionConfiguration (#11080) EncryptionConfig was renamed to EncryptedConfiguration and added to the `apiserver.config.k8s.io` API group in Kubernetes 1.13. The feature was previously in alpha and was not handling versions properly, which lead to an originally unnoticed `v1` in the docs. * content/zh/docs/reference/setup-tools/kubeadm/kubeadm-init.md * trsanlate create-cluster-kubeadm.md to chinese (#11041) * trsanlate create-cluster-kubeadm.md to chinese * Update create-cluster-kubeadm.md * update the feature stage in v1.13 (#11307) * update new feature gates to document (#11295) * refresh controller role list on rbac description page (#11290) * node labeling restriction docs (#10944) * Update 1.13 docs for CSI GA (#10893) * dynamic audit documentation (#9947) * adds dynamic audit documentation * Copyedit for clarity See also inline question/s * Fix feature state shortcode * Update feature state * changes wording for dynamic audit flag behavior * Minor copyedit * fix dynamic audit yaml * adds api enablement command to dynamic audit docs * change ordering dynamic audit appears in * add references to dynamic audit in webhook backend * reword dynamic audit reference * updates stages field for audit sink object * changes audit sink api definition; rewords policy * kubeadm: remove kube-proxy workaround (#11162) * zh-trans content/en/docs/setup/independent/install-kubeadm.md (#11338) * zh-trans content/en/docs/setup/independent/install-kubeadm.md * Update install-kubeadm.md * Update dry run feature to beta (#11140) * vSphere volume raw block support doc update (#10932) * Add docs for Windows DNS configurations (#10036) * Update docs for fields allowed at root of CRD schema (#9973) * Add docs for Windows DNS configurations * add device monitoring documentation (#9945) * kubeadm: adds upgrade instructions for 1.13 (#11138) * kubeadm: adds upgrade instructions for 1.13 Signed-off-by: Chuck Ha <[email protected]> * add minor copyedits Addressed a couple of copyedit comments a bit more cleanly. * kubeadm: add improvements to HA docs (#11094) * kubeadm: add information and diagrams for HA topologies * kubeadm: update HA doc with simplified steps * kubeadm: update HA doc with simplified steps * edit ha, add new topology topic, reorder by weight * troubleshoot markdown * fix more markdown, fix links * more markdown * more markdown * more markdown * changes after reviewer comments * add steps about Weave * update note about stacked topology * kubeadm external etcd HA upgrade 1.13 (#11364) * kubeadm external etcd HA upgrade 1.13 Signed-off-by: Ruben Orduz <[email protected]> * Update stacked controlplane steps * kubeadm cert documentation (#11093) * kubeadm certificate API and CSR documentation * copyedits * fix typo * PR for diff docs (#10789) * Empty commit against dev-1.13 for diff documentation * Complete Declarative maangement with diff commands * Second Korean l10n work for dev-1.13. (#11030) * Update outdated l10n(ko) contents (#10915) * Translate main menu for l10n(ko) docs (#10916) * Translate tasks/run-application/horizontal-pod-autoscale-walkthrough (#10980) * Translate content/ko/docs/concepts/overview/working-with-objects/kubernetes-object in Korean #11104 (#11332) * Pick-right-solution page translates into Korean. (#11340) * ko-trans: add jd/..., sap/..., ebay/..., homeoffice/... (#11336) * Translate concept/workloads/pods/pod-overview.md (#11092) Co-authored-by: June Yi <[email protected]> Co-authored-by: Jesang Myung <[email protected]> Co-authored-by: zerobig <[email protected]> Co-authored-by: Claudia J.Kang <[email protected]> Co-authored-by: lIuDuI <[email protected]> Co-authored-by: Woojin Na(Eddie) <[email protected]> * Rename encryption-at-rest related objects (#11059) EncryptionConfig was renamed to EncryptedConfiguration and added to the `apiserver.config.k8s.io` API group in Kubernetes 1.13. The feature was previously in alpha and was not handling versions properly, which lead to an originally unnoticed `v1` in the docs. Also, the `--experimental-encryption-provider-config` flag is now called just `--encryption-provider-config`. * Documenting FlexVolume Resize alpha feature. (#10097) * CR webhook conversion documentation (#10986) * CR Conversion * Addressing comments * Addressing more comments * Addressing even more comments * Addressing even^2 more comments * Remove references to etcd2 in v1.13 since support has been removed (#11414) * Remove etcd2 references as etcd2 is deprecated Link back to the v1.12 version of the etcd3 doc for the etcd2->etcd3 migration instructions. I updated the kube-apiserver reference manually, unsure if that is auto-generated somehow. The federation-apiserver can still potentially support etcd2 so I didn't touch that. * Remove outdated {master,node}.yaml files There are master/node yaml files that reference etcd2.service that are likely highly out of date. I couldn't find any docs that actually reference these templates so I removed them * Address review comments * Final Korean l10n work for dev-1.13 (#11440) * Update outdated l10n(ko) contents (#11425) fixes #11424 * Remove references to etcd2 in content/ko (#11416) * Resolve conflicts against master for /ko contents (#11438) * Fix unopened caution shortcode * kubeadm: update the reference docs for 1.13 (#10960) * docs update to promote TaintBasedEvictions to beta (#10765) * First Korean l10n work for dev-1.13 (#10719) * Update outdated l10n(ko) contents (#10689) fixes #10686 * Translate concepts/overview/what-is-kubernetes in Korean (#10690) * Translate concepts/overview/what-is-kubernetes in Korean * Feedback from ClaudiaJKang * Translate concepts/overview/components in Korean (#10882) * Translate concepts/overview/components in Korean #10717 * Translate concepts/overview/components in Korean * Translate concepts/overview/components in Korean * Apply Korean glossary: 서비스 어카운트 * Translate concepts/overview/kubernetes-api in Korean (#10773) * Translate concepts/overview/kubernetes-api in Korean * Applied feedback from ianychoi * kubeadm: update the configuration docs to v1beta1 (#10959) * kubeadm: add small v1beta1 related updates (#10988) * update new feature gates to document (#11295) * Update dry run feature to beta (#11140) * kubeadm: add improvements to HA docs (#11094) * kubeadm: add information and diagrams for HA topologies * kubeadm: update HA doc with simplified steps * kubeadm: update HA doc with simplified steps * edit ha, add new topology topic, reorder by weight * troubleshoot markdown * fix more markdown, fix links * more markdown * more markdown * more markdown * changes after reviewer comments * add steps about Weave * update note about stacked topology * kubeadm: update reference docs - add section about working with phases under kubeadm-init.md - update GA / beta status of features - kubeadm alpha phase was moved to kubeadm init phase - new commands were added under kubeadm alpha - included new CoreDNS usage examples * Generate components and tools reference * Add generated federation API Reference (#11491) * Add generated federation API Reference * Add front matter to federation reference * Remove whitespace from federation front matter * Remove more whitespace from federation front matter * Remove superfluous kubefed reference * Add frontmatter to generated kubefed reference * Fix kubefed reference page frontmatter * Generate kubectl reference docs 1.13 (#11487) * Generate kubectl reference docs 1.13 * Fix links in kubectl reference * Add 1.13 API reference (#11489) * Update config.toml (#11486) * Update config.toml Preparing for 1.13 release, updating the config.toml and dropping the 1.8 docs reference. * update dot releases and docsbranch typo * adding .Site. to Params.currentUrl (#11503) see #11502 for context * Add 1.13 Release notes (#11499)

kubeadm: adds upgrade instructions for 1.13

41a687f

Signed-off-by: Chuck Ha <[email protected]>

k8s-ci-robot requested review from neolit123 and timothysc November 20, 2018 18:56

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 20, 2018

k8s-ci-robot added language/en Issues or PRs related to English language size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 20, 2018

k8s-ci-robot assigned Bradamant3 Nov 20, 2018

neolit123 approved these changes Nov 20, 2018

View reviewed changes

k8s-ci-robot added sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. labels Nov 20, 2018

k8s-ci-robot assigned neolit123 Nov 20, 2018

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 20, 2018

tengqm reviewed Nov 21, 2018

View reviewed changes

Bradamant3 added this to the 1.13 milestone Nov 26, 2018

add minor copyedits

b28cf21

Addressed a couple of copyedit comments a bit more cleanly.

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 27, 2018

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 27, 2018

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 27, 2018

k8s-ci-robot merged commit e8bc2ce into kubernetes:dev-1.13 Nov 27, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

kubeadm: adds upgrade instructions for 1.13 #11138

kubeadm: adds upgrade instructions for 1.13 #11138

chuckha commented Nov 20, 2018

k8s-ci-robot commented Nov 20, 2018

k8sio-netlify-preview-bot commented Nov 20, 2018 •

edited

Loading

chuckha commented Nov 20, 2018

chuckha commented Nov 20, 2018

chuckha commented Nov 20, 2018

neolit123 left a comment

neolit123 commented Nov 20, 2018

rdodev commented Nov 20, 2018

neolit123 commented Nov 20, 2018

tengqm Nov 21, 2018

neolit123 Nov 21, 2018

tengqm Nov 21, 2018

Bradamant3 Nov 27, 2018

tengqm Nov 21, 2018

shavidissa Nov 21, 2018

neolit123 Nov 22, 2018

tengqm Nov 21, 2018

Bradamant3 commented Nov 27, 2018

k8s-ci-robot commented Nov 27, 2018


		## Upgrade master and node packages

		1. Prepare each node for maintenance, marking it unschedulable and evicting the workloads:

	1. Prepare each node for maintenance, marking it unschedulable and evicting the workloads:
	1. Prepare each node for maintenance, i.e. marking it unschedulable and evicting the workloads:

kubeadm: adds upgrade instructions for 1.13 #11138

kubeadm: adds upgrade instructions for 1.13 #11138

Conversation

chuckha commented Nov 20, 2018

k8s-ci-robot commented Nov 20, 2018

k8sio-netlify-preview-bot commented Nov 20, 2018 • edited Loading

chuckha commented Nov 20, 2018

chuckha commented Nov 20, 2018

chuckha commented Nov 20, 2018

neolit123 left a comment

Choose a reason for hiding this comment

neolit123 commented Nov 20, 2018

rdodev commented Nov 20, 2018

neolit123 commented Nov 20, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Bradamant3 commented Nov 27, 2018

k8s-ci-robot commented Nov 27, 2018

k8sio-netlify-preview-bot commented Nov 20, 2018 •

edited

Loading