kubeadm: add improvements to HA docs #11094

@neolit123
Thanks for this document
I have left some comments but almost all of them are not mandatory for v1.13 release and can be addressed with following PRs

content/en/docs/setup/independent/high-availability.md

fabriziopandini · 2018-11-27T18:50:18Z

content/en/docs/setup/independent/high-availability.md


-Copy the admin kubeconfig to the other control plane nodes:
+## Stacked etcd topology


I think we should clearly state that in this document we are considering stacked etcd cluster automatically created by kubeadm init and join.

Otherwise also a systemd managed etcd/an etcd cluster created with kubeadm phases installed on top of the control-plane machines qualifies as stacked etcd, but most of the following consideration about component coupling probably does not apply

@timothysc opinions?

content/en/docs/setup/independent/high-availability.md

neolit123 · 2018-11-27T19:19:24Z

@fabriziopandini

I have left some comments but almost all of them are not mandatory for v1.13 release

it's not clear what changes are mandatory from your review. please update or indicate to me which ones are.

fabriziopandini

two additional comments comments

content/en/docs/setup/independent/high-availability.md

fabriziopandini · 2018-11-27T19:29:54Z

content/en/docs/setup/independent/ha-topology.md

+
+{{% capture body %}}
+
+## Stacked etcd topology


reproposing comment after reshuffle
I think we should clearly state that in this document we are considering stacked etcd cluster automatically created by kubeadm init and join.

Otherwise also a systemd managed etcd/an etcd cluster created with kubeadm phases installed on top of the control-plane machines qualifies as stacked etcd, but most of the following consideration about component coupling probably does not apply

@timothysc opinions?

considering stacked etcd cluster automatically created by kubeadm init and join.

added a note about that in the new ha-topology page.

content/en/docs/setup/independent/high-availability.md

content/en/docs/setup/independent/ha-topology.md

neolit123 · 2018-11-27T21:31:50Z

solved feedback from comments, i don't have any more updates here AFAIK.
markdown looks OKish.

timothysc

/lgtm
/approve

Bradamant3 · 2018-11-28T02:07:22Z

/approve

k8s-ci-robot · 2018-11-28T02:07:42Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Bradamant3, timothysc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [Bradamant3]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

* kubeadm: add information and diagrams for HA topologies * kubeadm: update HA doc with simplified steps * kubeadm: update HA doc with simplified steps * edit ha, add new topology topic, reorder by weight * troubleshoot markdown * fix more markdown, fix links * more markdown * more markdown * more markdown * changes after reviewer comments * add steps about Weave * update note about stacked topology

* docs update to promote TaintBasedEvictions to beta (#10765) * First Korean l10n work for dev-1.13 (#10719) * Update outdated l10n(ko) contents (#10689) fixes #10686 * Translate concepts/overview/what-is-kubernetes in Korean (#10690) * Translate concepts/overview/what-is-kubernetes in Korean * Feedback from ClaudiaJKang * Translate concepts/overview/components in Korean (#10882) * Translate concepts/overview/components in Korean #10717 * Translate concepts/overview/components in Korean * Translate concepts/overview/components in Korean * Apply Korean glossary: 서비스 어카운트 * Translate concepts/overview/kubernetes-api in Korean (#10773) * Translate concepts/overview/kubernetes-api in Korean * Applied feedback from ianychoi * kubeadm: update the configuration docs to v1beta1 (#10959) * kubeadm: add small v1beta1 related updates (#10988) * update new feature gates to document (#11295) * Update dry run feature to beta (#11140) * kubeadm: add improvements to HA docs (#11094) * kubeadm: add information and diagrams for HA topologies * kubeadm: update HA doc with simplified steps * kubeadm: update HA doc with simplified steps * edit ha, add new topology topic, reorder by weight * troubleshoot markdown * fix more markdown, fix links * more markdown * more markdown * more markdown * changes after reviewer comments * add steps about Weave * update note about stacked topology * kubeadm: update reference docs - add section about working with phases under kubeadm-init.md - update GA / beta status of features - kubeadm alpha phase was moved to kubeadm init phase - new commands were added under kubeadm alpha - included new CoreDNS usage examples * Generate components and tools reference

* Update metadata.generation behaviour for custom resources (#10705) * update docs promoting plugins to beta (#10796) * docs update to promote TaintBasedEvictions to beta (#10765) * First Korean l10n work for dev-1.13 (#10719) * Update outdated l10n(ko) contents (#10689) fixes #10686 * Translate concepts/overview/what-is-kubernetes in Korean (#10690) * Translate concepts/overview/what-is-kubernetes in Korean * Feedback from ClaudiaJKang * Translate concepts/overview/components in Korean (#10882) * Translate concepts/overview/components in Korean #10717 * Translate concepts/overview/components in Korean * Translate concepts/overview/components in Korean * Apply Korean glossary: 서비스 어카운트 * Translate concepts/overview/kubernetes-api in Korean (#10773) * Translate concepts/overview/kubernetes-api in Korean * Applied feedback from ianychoi * kubeadm: update the configuration docs to v1beta1 (#10959) * kubeadm: add small v1beta1 related updates (#10988) * ADD content/zh/docs/reference/setup-tools/kubeadm/kubeadm.md (#11031) * ADD content/zh/docs/reference/setup-tools/kubeadm/kubeadm.md * ADD content/zh/docs/reference/setup-tools/kubeadm/generated/kubeadm_init.md * Update content/zh/docs/reference/setup-tools/kubeadm/kubeadm.md Accepted Co-Authored-By: YouthLab <[email protected]> * do not change 'master' or 'worker' nodes to '主从' * Doc updates for volume scheduling GA (#10743) * Doc updates for volume scheduling GA * Make trivial change to kick build * Document nodelease feature (#10699) * advanced audit doc for ModeBlockingStrict (#10203) * Rename EncryptionConfig to EncryptionConfiguration (#11080) EncryptionConfig was renamed to EncryptedConfiguration and added to the `apiserver.config.k8s.io` API group in Kubernetes 1.13. The feature was previously in alpha and was not handling versions properly, which lead to an originally unnoticed `v1` in the docs. * content/zh/docs/reference/setup-tools/kubeadm/kubeadm-init.md * trsanlate create-cluster-kubeadm.md to chinese (#11041) * trsanlate create-cluster-kubeadm.md to chinese * Update create-cluster-kubeadm.md * update the feature stage in v1.13 (#11307) * update new feature gates to document (#11295) * refresh controller role list on rbac description page (#11290) * node labeling restriction docs (#10944) * Update 1.13 docs for CSI GA (#10893) * dynamic audit documentation (#9947) * adds dynamic audit documentation * Copyedit for clarity See also inline question/s * Fix feature state shortcode * Update feature state * changes wording for dynamic audit flag behavior * Minor copyedit * fix dynamic audit yaml * adds api enablement command to dynamic audit docs * change ordering dynamic audit appears in * add references to dynamic audit in webhook backend * reword dynamic audit reference * updates stages field for audit sink object * changes audit sink api definition; rewords policy * kubeadm: remove kube-proxy workaround (#11162) * zh-trans content/en/docs/setup/independent/install-kubeadm.md (#11338) * zh-trans content/en/docs/setup/independent/install-kubeadm.md * Update install-kubeadm.md * Update dry run feature to beta (#11140) * vSphere volume raw block support doc update (#10932) * Add docs for Windows DNS configurations (#10036) * Update docs for fields allowed at root of CRD schema (#9973) * Add docs for Windows DNS configurations * add device monitoring documentation (#9945) * kubeadm: adds upgrade instructions for 1.13 (#11138) * kubeadm: adds upgrade instructions for 1.13 Signed-off-by: Chuck Ha <[email protected]> * add minor copyedits Addressed a couple of copyedit comments a bit more cleanly. * kubeadm: add improvements to HA docs (#11094) * kubeadm: add information and diagrams for HA topologies * kubeadm: update HA doc with simplified steps * kubeadm: update HA doc with simplified steps * edit ha, add new topology topic, reorder by weight * troubleshoot markdown * fix more markdown, fix links * more markdown * more markdown * more markdown * changes after reviewer comments * add steps about Weave * update note about stacked topology * kubeadm external etcd HA upgrade 1.13 (#11364) * kubeadm external etcd HA upgrade 1.13 Signed-off-by: Ruben Orduz <[email protected]> * Update stacked controlplane steps * kubeadm cert documentation (#11093) * kubeadm certificate API and CSR documentation * copyedits * fix typo * PR for diff docs (#10789) * Empty commit against dev-1.13 for diff documentation * Complete Declarative maangement with diff commands * Second Korean l10n work for dev-1.13. (#11030) * Update outdated l10n(ko) contents (#10915) * Translate main menu for l10n(ko) docs (#10916) * Translate tasks/run-application/horizontal-pod-autoscale-walkthrough (#10980) * Translate content/ko/docs/concepts/overview/working-with-objects/kubernetes-object in Korean #11104 (#11332) * Pick-right-solution page translates into Korean. (#11340) * ko-trans: add jd/..., sap/..., ebay/..., homeoffice/... (#11336) * Translate concept/workloads/pods/pod-overview.md (#11092) Co-authored-by: June Yi <[email protected]> Co-authored-by: Jesang Myung <[email protected]> Co-authored-by: zerobig <[email protected]> Co-authored-by: Claudia J.Kang <[email protected]> Co-authored-by: lIuDuI <[email protected]> Co-authored-by: Woojin Na(Eddie) <[email protected]> * Rename encryption-at-rest related objects (#11059) EncryptionConfig was renamed to EncryptedConfiguration and added to the `apiserver.config.k8s.io` API group in Kubernetes 1.13. The feature was previously in alpha and was not handling versions properly, which lead to an originally unnoticed `v1` in the docs. Also, the `--experimental-encryption-provider-config` flag is now called just `--encryption-provider-config`. * Documenting FlexVolume Resize alpha feature. (#10097) * CR webhook conversion documentation (#10986) * CR Conversion * Addressing comments * Addressing more comments * Addressing even more comments * Addressing even^2 more comments * Remove references to etcd2 in v1.13 since support has been removed (#11414) * Remove etcd2 references as etcd2 is deprecated Link back to the v1.12 version of the etcd3 doc for the etcd2->etcd3 migration instructions. I updated the kube-apiserver reference manually, unsure if that is auto-generated somehow. The federation-apiserver can still potentially support etcd2 so I didn't touch that. * Remove outdated {master,node}.yaml files There are master/node yaml files that reference etcd2.service that are likely highly out of date. I couldn't find any docs that actually reference these templates so I removed them * Address review comments * Final Korean l10n work for dev-1.13 (#11440) * Update outdated l10n(ko) contents (#11425) fixes #11424 * Remove references to etcd2 in content/ko (#11416) * Resolve conflicts against master for /ko contents (#11438) * Fix unopened caution shortcode * kubeadm: update the reference docs for 1.13 (#10960) * docs update to promote TaintBasedEvictions to beta (#10765) * First Korean l10n work for dev-1.13 (#10719) * Update outdated l10n(ko) contents (#10689) fixes #10686 * Translate concepts/overview/what-is-kubernetes in Korean (#10690) * Translate concepts/overview/what-is-kubernetes in Korean * Feedback from ClaudiaJKang * Translate concepts/overview/components in Korean (#10882) * Translate concepts/overview/components in Korean #10717 * Translate concepts/overview/components in Korean * Translate concepts/overview/components in Korean * Apply Korean glossary: 서비스 어카운트 * Translate concepts/overview/kubernetes-api in Korean (#10773) * Translate concepts/overview/kubernetes-api in Korean * Applied feedback from ianychoi * kubeadm: update the configuration docs to v1beta1 (#10959) * kubeadm: add small v1beta1 related updates (#10988) * update new feature gates to document (#11295) * Update dry run feature to beta (#11140) * kubeadm: add improvements to HA docs (#11094) * kubeadm: add information and diagrams for HA topologies * kubeadm: update HA doc with simplified steps * kubeadm: update HA doc with simplified steps * edit ha, add new topology topic, reorder by weight * troubleshoot markdown * fix more markdown, fix links * more markdown * more markdown * more markdown * changes after reviewer comments * add steps about Weave * update note about stacked topology * kubeadm: update reference docs - add section about working with phases under kubeadm-init.md - update GA / beta status of features - kubeadm alpha phase was moved to kubeadm init phase - new commands were added under kubeadm alpha - included new CoreDNS usage examples * Generate components and tools reference * Add generated federation API Reference (#11491) * Add generated federation API Reference * Add front matter to federation reference * Remove whitespace from federation front matter * Remove more whitespace from federation front matter * Remove superfluous kubefed reference * Add frontmatter to generated kubefed reference * Fix kubefed reference page frontmatter * Generate kubectl reference docs 1.13 (#11487) * Generate kubectl reference docs 1.13 * Fix links in kubectl reference * Add 1.13 API reference (#11489) * Update config.toml (#11486) * Update config.toml Preparing for 1.13 release, updating the config.toml and dropping the 1.8 docs reference. * update dot releases and docsbranch typo * adding .Site. to Params.currentUrl (#11503) see #11502 for context * Add 1.13 Release notes (#11499)

k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 19, 2018

k8s-ci-robot requested review from chuckha and fabriziopandini November 19, 2018 22:33

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 19, 2018

k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. language/en Issues or PRs related to English language labels Nov 19, 2018

k8s-ci-robot assigned Bradamant3 Nov 19, 2018

k8s-ci-robot added the priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. label Nov 19, 2018

k8s-ci-robot added the sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. label Nov 19, 2018

chuckha mentioned this pull request Nov 20, 2018

upgrade docs 1.12 => 1.13 (multi-control-plane and single control plane) kubernetes/kubeadm#1261

Closed

2 tasks

Bradamant3 added this to the 1.13 milestone Nov 20, 2018

k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 22, 2018

neolit123 changed the title ~~[WIP] kubeadm: add improvements to HA docs~~ kubeadm: add improvements to HA docs Nov 22, 2018

k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 22, 2018

neolit123 force-pushed the kubeadm-ha-improv branch from c6e5119 to cada60f Compare November 22, 2018 03:56

neolit123 force-pushed the kubeadm-ha-improv branch 4 times, most recently from 518ac66 to 6b2117b Compare November 22, 2018 04:27

xiangpengzhao reviewed Nov 22, 2018

View reviewed changes

content/en/docs/setup/independent/high-availability.md Outdated Show resolved Hide resolved

dixudx reviewed Nov 22, 2018

View reviewed changes

content/en/docs/setup/independent/high-availability.md Show resolved Hide resolved

content/en/docs/setup/independent/high-availability.md Outdated Show resolved Hide resolved

neolit123 force-pushed the kubeadm-ha-improv branch from 6b2117b to 45b7f48 Compare November 25, 2018 21:49

kubeadm: add information and diagrams for HA topologies

25a54e4

neolit123 force-pushed the kubeadm-ha-improv branch from 45b7f48 to 25a54e4 Compare November 25, 2018 21:50

k8s-ci-robot removed the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 25, 2018

k8s-ci-robot assigned fabriziopandini and timothysc Nov 27, 2018

JENNIFER RONDEAU added 2 commits November 27, 2018 13:52

fix more markdown, fix links

518f766

more markdown

4ba31c9

fabriziopandini approved these changes Nov 27, 2018

View reviewed changes

JENNIFER RONDEAU added 2 commits November 27, 2018 14:12

more markdown

3588be4

more markdown

9ac327b

fabriziopandini reviewed Nov 27, 2018

View reviewed changes

detiber reviewed Nov 27, 2018

View reviewed changes

timothysc suggested changes Nov 27, 2018

View reviewed changes

content/en/docs/setup/independent/ha-topology.md Outdated Show resolved Hide resolved

content/en/docs/setup/independent/ha-topology.md Show resolved Hide resolved

content/en/docs/setup/independent/ha-topology.md Show resolved Hide resolved

neolit123 added 2 commits November 27, 2018 22:53

changes after reviewer comments

5e0cd84

add steps about Weave

4fc63d0

timothysc approved these changes Nov 27, 2018

View reviewed changes

content/en/docs/setup/independent/ha-topology.md Show resolved Hide resolved

neolit123 force-pushed the kubeadm-ha-improv branch from 8ec8681 to a1edd57 Compare November 27, 2018 21:16

update note about stacked topology

f79e228

neolit123 force-pushed the kubeadm-ha-improv branch from a1edd57 to f79e228 Compare November 27, 2018 21:24

timothysc approved these changes Nov 27, 2018

View reviewed changes

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 27, 2018

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 28, 2018

k8s-ci-robot merged commit b1298cf into kubernetes:dev-1.13 Nov 28, 2018

neolit123 mentioned this pull request Nov 28, 2018

failing containers under stacked method, possible low memory kubernetes/kubeadm#1280

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

kubeadm: add improvements to HA docs #11094

kubeadm: add improvements to HA docs #11094

neolit123 commented Nov 19, 2018 •

edited

Loading

k8sio-netlify-preview-bot commented Nov 19, 2018 •

edited

Loading

neolit123 commented Nov 19, 2018

neolit123 commented Nov 19, 2018

neolit123 commented Nov 22, 2018

neolit123 commented Nov 27, 2018

fabriziopandini left a comment

fabriziopandini Nov 27, 2018

neolit123 commented Nov 27, 2018 •

edited

Loading

fabriziopandini left a comment

fabriziopandini Nov 27, 2018

neolit123 Nov 27, 2018 •

edited

Loading

neolit123 commented Nov 27, 2018

timothysc left a comment

Bradamant3 commented Nov 28, 2018

k8s-ci-robot commented Nov 28, 2018


		Copy the admin kubeconfig to the other control plane nodes:
		## Stacked etcd topology

kubeadm: add improvements to HA docs #11094

kubeadm: add improvements to HA docs #11094

Conversation

neolit123 commented Nov 19, 2018 • edited Loading

k8sio-netlify-preview-bot commented Nov 19, 2018 • edited Loading

neolit123 commented Nov 19, 2018

neolit123 commented Nov 19, 2018

neolit123 commented Nov 22, 2018

neolit123 commented Nov 27, 2018

fabriziopandini left a comment

Choose a reason for hiding this comment

fabriziopandini Nov 27, 2018

Choose a reason for hiding this comment

neolit123 commented Nov 27, 2018 • edited Loading

fabriziopandini left a comment

Choose a reason for hiding this comment

fabriziopandini Nov 27, 2018

Choose a reason for hiding this comment

neolit123 Nov 27, 2018 • edited Loading

Choose a reason for hiding this comment

neolit123 commented Nov 27, 2018

timothysc left a comment

Choose a reason for hiding this comment

Bradamant3 commented Nov 28, 2018

k8s-ci-robot commented Nov 28, 2018

neolit123 commented Nov 19, 2018 •

edited

Loading

k8sio-netlify-preview-bot commented Nov 19, 2018 •

edited

Loading

neolit123 commented Nov 27, 2018 •

edited

Loading

neolit123 Nov 27, 2018 •

edited

Loading