Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set languagedirection for localizations #22732

Closed
sftim opened this issue Jul 25, 2020 · 4 comments · Fixed by #22735
Closed

Set languagedirection for localizations #22732

sftim opened this issue Jul 25, 2020 · 4 comments · Fixed by #22735
Assignees
@SaiHarshaK
Labels
area/web-development Issues or PRs related to the kubernetes.io's infrastructure, design, or build processes good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. priority/backlog Higher priority than priority/awaiting-more-evidence.

Comments

@sftim
Copy link
Contributor

sftim commented Jul 25, 2020

This is a Feature Request

What would you like to be added
In config.toml, set languagedirection for all localizations. The value will be rtl for languages usually written right-to-left, or ltr for languages usually written left-to-right.

Why is this needed
This is part of #22730

Comments
/kind feature
/area web-development
/good-first-issue
/priority backlog
@k8s-ci-robot
Copy link
Contributor

@sftim:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

This is a Feature Request

What would you like to be added
In config.toml, set languagedirection for all localizations. The value will be rtl for languages usually written right-to-left, or ltr for languages usually written left-to-right.

Why is this needed
This is part of #22730

Comments
/kind feature
/area web-development
/good-first-issue
/priority backlog

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. area/web-development Issues or PRs related to the kubernetes.io's infrastructure, design, or build processes good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. priority/backlog Higher priority than priority/awaiting-more-evidence. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Jul 25, 2020
@sftim
Copy link
Contributor Author

sftim commented Jul 25, 2020

As of commit 4e81aa8, all existing localizations are written left-to-right.

@sftim
Copy link
Contributor Author

sftim commented Jul 25, 2020

Anyone can work on this. If you're picking up this issue and would like help before you open a pull request, reply here with a request for advice.

@SaiHarshaK
Copy link
Contributor

/assign

@SaiHarshaK SaiHarshaK mentioned this issue Jul 25, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SaiHarshaK SaiHarshaK

Labels
area/web-development Issues or PRs related to the kubernetes.io's infrastructure, design, or build processes good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. priority/backlog Higher priority than priority/awaiting-more-evidence.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add languagedirection in config.toml SaiHarshaK/website
3 participants
@k8s-ci-robot @sftim @SaiHarshaK