Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add languagedirection in config.toml #22735

Merged
merged 1 commit into from
Jul 26, 2020
Merged

Add languagedirection in config.toml #22735

merged 1 commit into from
Jul 26, 2020

Conversation

SaiHarshaK
Copy link
Contributor

This PR adds languagedirection field to the localizations in config.toml.

Fixes #22732

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Jul 25, 2020
@sftim
Copy link
Contributor

sftim commented Jul 25, 2020

I think you need to use "ltr" (and "rtl") inside quotes.

@sftim
Copy link
Contributor

sftim commented Jul 25, 2020

That was commendably fast @SaiHarshaK !

@SaiHarshaK
Copy link
Contributor Author

I think you need to use "ltr" (and "rtl") inside quotes.

I just noticed and updated.

@sftim
Copy link
Contributor

sftim commented Jul 25, 2020

LGTM (will wait for preview before reviewing formally)

@netlify
Copy link

netlify bot commented Jul 25, 2020

Deploy preview for kubernetes-io-master-staging ready!

Built with commit ee02334

https://deploy-preview-22735--kubernetes-io-master-staging.netlify.app

@sftim
Copy link
Contributor

sftim commented Jul 25, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 25, 2020
@SaiHarshaK
Copy link
Contributor Author

@sftim Will this be approved along with the parent issue?

@sftim
Copy link
Contributor

sftim commented Jul 26, 2020

@SaiHarshaK this change does look good to me. If one of the approvers agrees, this can merge (approvers are mostly volunteers, so although we try to review changes promptly, getting a change merged can take a while).

@makoscafee
Copy link
Contributor

thanks @SaiHarshaK
/LGTM
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: makoscafee

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 26, 2020
@k8s-ci-robot k8s-ci-robot merged commit f9fa4dd into kubernetes:master Jul 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@makoscafee makoscafee makoscafee approved these changes

@zparnold zparnold Awaiting requested review from zparnold

Assignees

@makoscafee makoscafee

@sftim sftim

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Set languagedirection for localizations
4 participants
@SaiHarshaK @sftim @makoscafee @k8s-ci-robot