Right-to-left language support #22730

sftim · 2020-07-25T12:55:31Z

This is a Feature Request

What would you like to be added
Add support for serving the Kubernetes website and displaying it in a right-to-left language such as Arabic, Hebrew or Urdu.

Why is this needed
On the web, content is usually rendered horizontally. Existing merged localizations are all right-to-left, or can be (Chinese and Japanese, for example, are also sometimes written top-to-bottom starting top right).

Comments
We'll need this as part of adding Arabic and Persian.

This is likely to form an umbrella issue with child issues to cover specific topics.

/area web-development

sftim · 2020-07-25T13:05:30Z

/kind feature
/priority important-longterm

celestehorgan · 2020-07-25T18:09:51Z

For visibility adding generalized support for this is an open issue in hugo: gohugoio/hugo#3255. This issue also proposes a reasonable stop-gap solution.

fejta-bot · 2020-10-23T19:01:29Z

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

fejta-bot · 2020-11-22T19:45:04Z

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

fejta-bot · 2020-12-22T20:28:59Z

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

k8s-ci-robot · 2020-12-22T20:29:13Z

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

sftim · 2022-10-27T09:40:45Z

Also see #37546

sftim · 2024-02-06T18:52:59Z

/reopen

k8s-ci-robot · 2024-02-06T18:53:05Z

@sftim: Reopened this issue.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

sftim · 2024-02-06T18:53:16Z

/remove-lifecycle rotten
/lifecycle frozen
/triage accepted

/area localization

mboukhalfa · 2024-02-07T13:33:17Z

In his preview we can see the issue with the logo position when changing the language to Arabic :
https://deploy-preview-45056--kubernetes-io-main-staging.netlify.app/ar/

sftim · 2024-05-11T18:31:28Z

The key things I think we should do are:

set dir attributes on the <html> or <body> element of all pages (whatever locale they are in). Hugo already knows the text direction for each localization. Pick one of <html> or <body> and stick with that choice
validate that the header and footer work the way we want in RTL locales (making fixes if needed)
- and without LTR locale regressions
check if we want RTL versions of the Kubernetes and CNCF logos (the action is to check, nothing more at this stage)
validate that https://kubernetes.io/releases/download/ works right for RTL locales, because this page has a bunch of custom layouts, and is important to get right
validate that https://kubernetes.io/docs/home/supported-doc-versions/ works right for RTL locales (it should just work!)

ricardoamaro · 2024-05-15T17:10:51Z

Per the SIG docs meeting and as a follow-up, could we try segregating the work in consumable chunks that several people could pick up independently?

mboukhalfa · 2024-05-15T18:05:11Z

Per the SIG docs meeting and as a follow-up, could we try segregating the work in consumable chunks that several people could pick up independently?

Probably we can open a discussion on github and also slack and we go through the following points :

Identify clearly the issues and their scope (k8s / docsy / specific CSS file or layout)
Set how solution should look like and also its scope (push fix to docy / k8s for all the website / keep the fix only for RTL lang example )
Create couple of issues each with a clear technical problem and describe how to fix

chalin · 2024-05-15T18:54:35Z

FYI, I've slated some time this week to start working on Docsy RTL support (google/docsy#1442). I'm off next week, so I don't know when it'll get wrapped up. Again, FYI.

Side note: there still doesn't seem to be a lot of interest for Docsy RTL support if I judge from the number of 👍. @ricardoamaro et al., if you haven't already, could you given google/docsy#1442 a thumbs up?

sftim · 2024-05-15T20:04:53Z

@chalin if you want to talk about the challenges in broad strokes (I don't speak any language usually written RTL, so I'm not the right person for fine details), I can make time in the next few months. Nudge me on K8s Slack if this sounds useful.

chalin · 2024-05-16T08:38:51Z

Here's a preview of Docsy RTL support: https://deploy-preview-2002--docsydocs.netlify.app/docs/ using the en but configured as if an rtl language. @mboukhalfa et al., let me know what you think.

Edit: if it looks ok overall, I can update the Docsy example, which has pages written in an actual RTL language for a better preview.

Thanks for the offer @sftim, I may take you up on it if necessary -- maybe the changes illustrated above cover the necessary bases?

mboukhalfa · 2024-05-16T08:48:01Z

Here's a preview of Docsy RTL support: https://deploy-preview-2002--docsydocs.netlify.app/docs/ using the en but configured as if an rtl language. @mboukhalfa et al., let me know what you think.

Thanks for the offer @sftim, I may take you up on it if necessary -- maybe the changes illustrated above cover the necessary bases?

Thanks @chalin That preview seems managing the navbar nicely but I still can see an issue with current page path, the slash is not in the correct place :

I am sure on the docsy example it would look much better than what we have on k8s because on k8s we are not using native docsy layout for navbar and navbar-brand our customization cause us more troubles

sftim · 2024-05-16T09:18:04Z

I think we could switch Kubernetes to native layouts more (see #41171)

chalin · 2024-05-16T09:29:37Z

@mboukhalfa et al. - could you have another look at the preview, I've fixed some issues: https://deploy-preview-2002--docsydocs.netlify.app/docs/language/

mboukhalfa · 2024-05-16T09:38:21Z

@mboukhalfa et al. - could you have another look at the preview, I've fixed some issues: https://deploy-preview-2002--docsydocs.netlify.app/docs/language/

Great work @chalin looks good to me from the preview I will take a detailed look later and check the implementation If you can link me to the code PR would be nice ! I am not sure if the menu with small device preview stay in horizontal list still the expected behavior ?

sftim · 2024-05-16T09:42:38Z

If you can link me to the code PR would be nice ! I am not sure if the menu with small device preview stay in horizontal list still the expected behavior ?

It's google/docsy#2002

chalin · 2024-05-17T01:06:21Z

Persian Docsy example pages: https://example.docsy.dev/fa/docs/
If you have questions or comment about Docsy RTL, add them to one of:
- Display Persian (fa) pages in right-to-left (RTL) fashion & other improvements google/docsy-example#295
- Reintroduce RTL support using BSv5 RTLCSS google/docsy#1442

sftim · 2024-06-11T14:01:35Z

I've linked some PRs to #41171 that help pave the way to using more upstream Docsy support, and eventually to adding RTL language support.

chalin · 2024-10-10T18:39:42Z

Status update: after a change in implementation strategy, Docsy's RTL support is looking good. All known issues (e.g., with the navs and footer) have been resolved. Site previews:

https://example.docsy.dev/fa/docs/overview/
https://rtl--docsydocs.netlify.app - an en version of the Docsy website, but set with RTL as language direction. This helps me figure out what I'm looking at (I can't read Persian :)), and validate that the light/dark mode dropdown is now working.

As was mentioned before, if you have questions or comment about Docsy RTL, add them to one of:

Reintroduce RTL support using BSv5 RTLCSS google/docsy#1442 -- this is the main tracker issue (FYI)
Display Persian (fa) pages in right-to-left (RTL) fashion & other improvements google/docsy-example#295

If no other issues are found, then I'll be updating the Docsy docs to explain how to set up RTL support, and then publish an official version. Please give a thumbs up to google/docsy#1442 if you haven't already.

adowair · 2024-10-13T19:20:52Z

Thank you for pushing this through the long haul @chalin—we're looking forward to pulling this into Kubernetes!

k8s-ci-robot added the area/web-development Issues or PRs related to the kubernetes.io's infrastructure, design, or build processes label Jul 25, 2020

sftim mentioned this issue Jul 25, 2020

Set languagedirection for localizations #22732

Closed

k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. labels Jul 25, 2020

sftim mentioned this issue Jul 26, 2020

Set right-to-left direction using CSS #22731

Closed

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 23, 2020

k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Nov 22, 2020

k8s-ci-robot closed this as completed Dec 22, 2020

divya-mohan0209 added this to SIG Docs Longterm issues Aug 17, 2023

divya-mohan0209 moved this to Todo in SIG Docs Longterm issues Aug 17, 2023

divya-mohan0209 removed this from SIG Docs Longterm issues Aug 17, 2023

k8s-ci-robot reopened this Feb 6, 2024

k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Feb 6, 2024

nate-double-u mentioned this issue Feb 6, 2024

Reintroduce RTL support using BSv5 RTLCSS google/docsy#1442

Closed

22 tasks

sftim mentioned this issue Feb 10, 2024

Logo Overlaps with Menu in RTL Languages #45077

Closed

sftim mentioned this issue May 1, 2024

Set text direction based on localization text direction #46100

Open

sftim mentioned this issue May 13, 2024

Redo code_sample shortcode #46362

Merged

chalin mentioned this issue May 16, 2024

[RTL] Breadcrumb separator is in the wrong place google/docsy#2004

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Right-to-left language support #22730

Right-to-left language support #22730

sftim commented Jul 25, 2020

sftim commented Jul 25, 2020

celestehorgan commented Jul 25, 2020

fejta-bot commented Oct 23, 2020

fejta-bot commented Nov 22, 2020

fejta-bot commented Dec 22, 2020

k8s-ci-robot commented Dec 22, 2020

sftim commented Oct 27, 2022

sftim commented Feb 6, 2024

k8s-ci-robot commented Feb 6, 2024

sftim commented Feb 6, 2024

mboukhalfa commented Feb 7, 2024

sftim commented May 11, 2024 •

edited

Loading

ricardoamaro commented May 15, 2024 •

edited

Loading

mboukhalfa commented May 15, 2024 •

edited

Loading

chalin commented May 15, 2024 •

edited

Loading

sftim commented May 15, 2024 •

edited

Loading

chalin commented May 16, 2024 •

edited

Loading

mboukhalfa commented May 16, 2024

sftim commented May 16, 2024

chalin commented May 16, 2024

mboukhalfa commented May 16, 2024

sftim commented May 16, 2024

chalin commented May 17, 2024

sftim commented Jun 11, 2024

chalin commented Oct 10, 2024

adowair commented Oct 13, 2024

Right-to-left language support #22730

Right-to-left language support #22730

Comments

sftim commented Jul 25, 2020

sftim commented Jul 25, 2020

celestehorgan commented Jul 25, 2020

fejta-bot commented Oct 23, 2020

fejta-bot commented Nov 22, 2020

fejta-bot commented Dec 22, 2020

k8s-ci-robot commented Dec 22, 2020

sftim commented Oct 27, 2022

sftim commented Feb 6, 2024

k8s-ci-robot commented Feb 6, 2024

sftim commented Feb 6, 2024

mboukhalfa commented Feb 7, 2024

sftim commented May 11, 2024 • edited Loading

ricardoamaro commented May 15, 2024 • edited Loading

mboukhalfa commented May 15, 2024 • edited Loading

chalin commented May 15, 2024 • edited Loading

sftim commented May 15, 2024 • edited Loading

chalin commented May 16, 2024 • edited Loading

mboukhalfa commented May 16, 2024

sftim commented May 16, 2024

chalin commented May 16, 2024

mboukhalfa commented May 16, 2024

sftim commented May 16, 2024

chalin commented May 17, 2024

sftim commented Jun 11, 2024

chalin commented Oct 10, 2024

adowair commented Oct 13, 2024

sftim commented May 11, 2024 •

edited

Loading

ricardoamaro commented May 15, 2024 •

edited

Loading

mboukhalfa commented May 15, 2024 •

edited

Loading

chalin commented May 15, 2024 •

edited

Loading

sftim commented May 15, 2024 •

edited

Loading

chalin commented May 16, 2024 •

edited

Loading