Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove kube-deploy tests for the cluster api code. #8694

Merged
merged 1 commit into from
Jul 16, 2018

Conversation

roberthbailey
Copy link
Contributor

Basically undoing #6761 and #6792. This will unblock merging kubernetes-retired/kube-deploy#704.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 16, 2018
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 16, 2018
@krousey
Copy link
Contributor

krousey commented Jul 16, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 16, 2018
@krzyzacy
Copy link
Member

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: krousey, krzyzacy, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 16, 2018
@k8s-ci-robot k8s-ci-robot merged commit 18bb81c into kubernetes:master Jul 16, 2018
@k8s-ci-robot
Copy link
Contributor

@roberthbailey: Updated the following 2 configmaps:

  • config configmap using the following files:
    • key config.yaml using file prow/config.yaml
  • plugins configmap using the following files:
    • key plugins.yaml using file prow/plugins.yaml

In response to this:

Basically undoing #6761 and #6792. This will unblock merging kubernetes-retired/kube-deploy#704.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@roberthbailey roberthbailey deleted the cleanup-kube-deploy branch July 20, 2018 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants