Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Turning on PR testing for kube-deploy #6792

Merged
merged 1 commit into from
Feb 15, 2018
Merged

Turning on PR testing for kube-deploy #6792

merged 1 commit into from
Feb 15, 2018

Conversation

krousey
Copy link
Contributor

@krousey krousey commented Feb 12, 2018

will wait until CI goes green
/hold

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 12, 2018
@krousey
Copy link
Contributor Author

krousey commented Feb 13, 2018

/assign @BenTheElder @krzyzacy

BenTheElder
BenTheElder approved these changes Feb 13, 2018
View reviewed changes
Copy link
Member

@BenTheElder BenTheElder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 13, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, krousey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these OWNERS Files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 13, 2018
@krousey
Copy link
Contributor Author

krousey commented Feb 15, 2018

/unhold
flaky tests have been fixed

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 15, 2018
@krousey
Copy link
Contributor Author

krousey commented Feb 15, 2018

ref: kubernetes-retired/kube-deploy#544

@k8s-ci-robot k8s-ci-robot merged commit 2b5d78a into kubernetes:master Feb 15, 2018
@k8s-ci-robot
Copy link
Contributor

@krousey: Updated the config configmap

In response to this:

will wait until CI goes green
/hold

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@krousey krousey mentioned this pull request Feb 16, 2018
Closed
5 tasks
@rsdcastro rsdcastro mentioned this pull request Apr 12, 2018
Closed
5 tasks
@roberthbailey roberthbailey mentioned this pull request Jul 16, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenTheElder BenTheElder BenTheElder approved these changes

@krzyzacy krzyzacy Awaiting requested review from krzyzacy

Assignees

@BenTheElder BenTheElder

@krzyzacy krzyzacy

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@krousey @k8s-ci-robot @BenTheElder @krzyzacy