Adding PR jobs for kube-deploy #6761

krousey · 2018-02-09T18:30:23Z

cc @kubernetes/kube-deploy-maintainers

krousey · 2018-02-09T18:31:40Z

/hold

It should be noted I have no idea what I'm doing. 😄. Is there a way to have the test job run, but not block merge? We need to fix tests.

krousey · 2018-02-09T18:33:39Z

prow/config.yaml

+    trigger: "/test( all| pull-kube-deploy-build)"
+    spec:
+      containers:
+      - image: gcr.io/k8s-testimages/gcloud-in-go:v20171113-192bec25


I just picked an image that seemed like it might work. I don't know how to test this. The only thing these jobs depend on is go 1.9+

ref https://github.com/kubernetes/test-infra/blob/master/images/gcloud/Dockerfile, yeah it's go 1.9.3 with an ancient gcloud

krousey · 2018-02-09T18:37:33Z

/test pull-test-infra-verify-spelling

krousey · 2018-02-09T18:43:55Z

Needed to rebase to pick up the spelling test script.

krzyzacy · 2018-02-09T18:53:36Z

/skip

krzyzacy · 2018-02-09T18:55:59Z

wanna add them to testgrid as well? (add your repo here)

krousey · 2018-02-09T19:03:21Z

@krzyzacy Sure I can add test-grid as well. I assume that I would have to create periodic jobs as well? Also, is there a way to run the tests on PRs but not have them block? (we have failures we need to fix right now)

krzyzacy · 2018-02-09T19:06:14Z

@krousey how does merge work in your repo?

BenTheElder · 2018-02-09T19:07:06Z

Also, is there a way to run the tests on PRs but not have them block?

Guessing you are using tide, in which case you can but you set the jobs to skip_report: true so they show up on gubernator / prow.k8s.io / testgrid but not as a github status.

krzyzacy · 2018-02-09T19:10:55Z

(also https://github.com/kubernetes/test-infra/blob/master/testgrid/config.yaml)

krousey · 2018-02-09T19:28:28Z

@krzyzacy Done. Should I add periodic CI jobs too? and what about alerting? I'm unsure what that does.

krzyzacy · 2018-02-09T19:32:36Z

@krousey up to you if you want to add a CI job or not.

alert will send you email alerts when your job fails x times in a row

krousey · 2018-02-09T21:47:59Z

Fixed latest test errors and added CI jobs too.

krzyzacy · 2018-02-09T21:50:49Z

prow/config.yaml

@@ -4935,6 +4965,29 @@ postsubmits:
      - name: docker-graph
        hostPath:
          path: /mnt/disks/ssd0/docker-graph
+
+  kubernetes/kube-deploy:


I would add them as periodic jobs rather than postsubmits?

Ok. What is the purpose of post-submits? Just stuff you don't want to run on every commit in every PR?

It's the opposite right? Postsubmits are the stuff you do want to run on every commit in every PR :-)

there are jobs like config updater, need to run right after a push event...

What does this job do exactly? post-submits are best used for things like uploading a new config after the config change is merged, IE some post-merge publish step.

Continuous tests are probably best as periodics and/or presubmits.

Got it. It's just CI builds... periodic it is.

krousey · 2018-02-09T22:11:33Z

/hold cancel

krzyzacy · 2018-02-09T22:15:01Z

prow/config.yaml

+    containers:
+    - image: gcr.io/k8s-testimages/gcloud-in-go:v20171113-192bec25
+      args:
+      - "--repo=k8s.io/$(REPO_NAME)"


periodics don't have $(REPO_NAME), so specify your checkout path :-)

and also add labels: preset-service-account: true for log/aftifacts upload stuff

k8s-ci-robot · 2018-02-09T22:41:12Z

@krousey: The following test failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
pull-test-infra-verify-spelling	`32c4fac`	link	`/test pull-test-infra-verify-spelling`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

krzyzacy · 2018-02-09T22:43:53Z

testgrid/config.yaml

@@ -156,6 +156,10 @@ test_groups:
  gcs_prefix: kubernetes-jenkins/logs/ci-ingress-gce-upgrade-e2e
 - name: ci-ingress-gce-downgrade-e2e
  gcs_prefix: kubernetes-jenkins/logs/ci-ingress-gce-downgrade-e2e
+- name: ci-kube-deploy-build
+  gcs_prefix: kubernetes-jenkins/logs/ci-kube-deploy-build
+- name: ci-kube-deploy-build


s/build/test

krzyzacy · 2018-02-09T22:50:28Z

I think you'll also need to enable trigger in https://github.com/kubernetes/test-infra/blob/master/prow/plugins.yaml#L188-L190

cc @cjwagner sounds like we want a unit-test to ensure all repo has prow presubmits has trigger enabled?

otherwise lgtm

krzyzacy · 2018-02-09T22:58:41Z

/lgtm

k8s-ci-robot · 2018-02-09T22:58:48Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: krousey, krzyzacy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these OWNERS Files:

~~OWNERS~~ [krzyzacy]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot · 2018-02-09T23:16:53Z

@krousey: Updated the following 2 configmaps:

config
plugins

In response to this:

cc @kubernetes/kube-deploy-maintainers

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

krousey · 2018-02-12T19:25:49Z

ref kubernetes-retired/kube-deploy#544

krousey requested review from BenTheElder and krzyzacy as code owners February 9, 2018 18:30

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 9, 2018

k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 9, 2018

krousey commented Feb 9, 2018

View reviewed changes

krousey force-pushed the kube-deploy branch from 32122ad to 32c4fac Compare February 9, 2018 18:43

krousey force-pushed the kube-deploy branch from 32c4fac to fb6a2b1 Compare February 9, 2018 19:01

krousey requested a review from michelle192837 as a code owner February 9, 2018 19:01

krousey force-pushed the kube-deploy branch from fb6a2b1 to c5f8944 Compare February 9, 2018 19:27

krousey force-pushed the kube-deploy branch 2 times, most recently from ab9c183 to c479b8f Compare February 9, 2018 21:46

k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 9, 2018

krzyzacy reviewed Feb 9, 2018

View reviewed changes

krousey force-pushed the kube-deploy branch from c479b8f to a5719ed Compare February 9, 2018 22:04

k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 9, 2018

krzyzacy reviewed Feb 9, 2018

View reviewed changes

Adding PR jobs for kube-deploy

0bae11d

krousey force-pushed the kube-deploy branch 2 times, most recently from fbbc3e2 to 65d9e26 Compare February 9, 2018 22:31

krzyzacy reviewed Feb 9, 2018

View reviewed changes

Adding CI jobs for kube-deploy

3ec23a9

krousey force-pushed the kube-deploy branch from 65d9e26 to 3ec23a9 Compare February 9, 2018 22:44

Enable the trigger plugin for kube-deploy

9dfad3d

krousey requested review from cjwagner and 0xmichalis as code owners February 9, 2018 22:53

k8s-ci-robot assigned krzyzacy Feb 9, 2018

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 9, 2018

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 9, 2018

k8s-ci-robot merged commit b500734 into kubernetes:master Feb 9, 2018

krousey mentioned this pull request Feb 16, 2018

Run more automated checks on kube-deploy repo kubernetes-retired/kube-deploy#613

Closed

5 tasks

rsdcastro mentioned this pull request Apr 12, 2018

Run more automated checks on cluster-api repo kubernetes-sigs/cluster-api#43

Closed

5 tasks

roberthbailey mentioned this pull request Jul 16, 2018

Remove kube-deploy tests for the cluster api code. #8694

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding PR jobs for kube-deploy #6761

Adding PR jobs for kube-deploy #6761

krousey commented Feb 9, 2018

krousey commented Feb 9, 2018

krousey Feb 9, 2018

krzyzacy Feb 9, 2018

krousey commented Feb 9, 2018

krousey commented Feb 9, 2018

krzyzacy commented Feb 9, 2018

krzyzacy commented Feb 9, 2018

krousey commented Feb 9, 2018

krzyzacy commented Feb 9, 2018

BenTheElder commented Feb 9, 2018

krzyzacy commented Feb 9, 2018

krousey commented Feb 9, 2018

krzyzacy commented Feb 9, 2018

krousey commented Feb 9, 2018

krzyzacy Feb 9, 2018

krousey Feb 9, 2018

krzyzacy Feb 9, 2018

BenTheElder Feb 9, 2018

krousey Feb 9, 2018

krousey commented Feb 9, 2018

krzyzacy Feb 9, 2018

k8s-ci-robot commented Feb 9, 2018 •

edited

Loading

krzyzacy Feb 9, 2018

krousey Feb 9, 2018

krzyzacy commented Feb 9, 2018 •

edited

Loading

krzyzacy commented Feb 9, 2018

k8s-ci-robot commented Feb 9, 2018

k8s-ci-robot commented Feb 9, 2018

krousey commented Feb 12, 2018

Adding PR jobs for kube-deploy #6761

Adding PR jobs for kube-deploy #6761

Conversation

krousey commented Feb 9, 2018

krousey commented Feb 9, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

krousey commented Feb 9, 2018

krousey commented Feb 9, 2018

krzyzacy commented Feb 9, 2018

krzyzacy commented Feb 9, 2018

krousey commented Feb 9, 2018

krzyzacy commented Feb 9, 2018

BenTheElder commented Feb 9, 2018

krzyzacy commented Feb 9, 2018

krousey commented Feb 9, 2018

krzyzacy commented Feb 9, 2018

krousey commented Feb 9, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

krousey commented Feb 9, 2018

Choose a reason for hiding this comment

k8s-ci-robot commented Feb 9, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

krzyzacy commented Feb 9, 2018 • edited Loading

krzyzacy commented Feb 9, 2018

k8s-ci-robot commented Feb 9, 2018

k8s-ci-robot commented Feb 9, 2018

krousey commented Feb 12, 2018

k8s-ci-robot commented Feb 9, 2018 •

edited

Loading

krzyzacy commented Feb 9, 2018 •

edited

Loading