Allow running e2e tests as presubmits on GitHub #30927

uroy-personal · 2023-10-01T23:08:44Z

No description provided.

linux-foundation-easycla · 2023-10-01T23:08:47Z

The committers listed above are authorized under a signed CLA.

✅ login: hongkailiu / name: Hongkai Liu (a278493)
✅ login: ameukam / name: Arnaud M. (b36e534)
✅ login: rjsadow / name: Ricky Sadowski (9aa814e)
✅ login: Priyankasaggu11929 / name: Priyanka Saggu (37409a8)
✅ login: upodroid / name: Mahamed Ali (44d581f)
✅ login: uroy-personal / name: Umesh Roy (ffc4ccb, 90b19c6, 175b482, 1fbd7a5)

k8s-ci-robot · 2023-10-01T23:08:52Z

Hi @uroy-personal. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

uroy-personal · 2023-10-01T23:19:10Z

For the issue : kubernetes/autoscaler#5918

uroy-personal · 2023-10-01T23:20:08Z

/assign @jbartosik @kgolab @pbetkier

uroy-personal · 2023-10-01T23:25:40Z

Good Morning @jbartosik , @kgolab , @pbetkier , @mwielgus & @bskiba.

I had to close the PR : #30893 as my fork got corrupted while rebasing the changes from parent repository.

@pbetkier , All the review comments from the previous PR has been incorporated here. I would like to request your review again on this PR.
Thanks again for your thorough assistance on this change.

uroy-personal · 2023-10-01T23:50:57Z

I have signed the EasyCLA already. Hope the "EasyCLA — Missing CLA Authorization" check will be cleared soon

pbetkier · 2023-10-02T06:14:45Z

/ok-to-test

Looks fine to me, but let @kwiesmueller handle this as the new owner :)

kwiesmueller · 2023-10-02T13:10:17Z

Tests fail with:

could not write config: 1 error occurred:
	* found duplicate name after normalizing: (DashboardTab) autoscalingvpafull

I think you have to rename the new presubmits.

kwiesmueller · 2023-10-02T13:10:43Z

Or rather use a different dashboard name?

uroy-personal · 2023-10-02T13:28:17Z

Good Morning @kwiesmueller ,
Yes this dashboard name has been used in the sig-autoscaling-config.yaml ( line no 139 ). Let me change the name. What name should we use?
autoscaling-vpa-full-presubmits?

kwiesmueller · 2023-10-02T13:42:13Z

That name sounds good, yes.

uroy-personal · 2023-10-02T13:49:25Z

/retest

uroy-personal · 2023-10-02T14:22:41Z

/retest-required

umesh-roy-sp · 2023-10-02T15:16:05Z

Hi @kwiesmueller ,
I made the changes and trigger retest. The pull-test-infra-verify-lint test is failing with the message:

config/prow/cluster/build/build_kubernetes-external-secrets_deployment.yaml
39:11 warning comment not indented like content (comments-indentation)
ERROR: yamllint failed

I have not been able to identity the issue so far. When I validate the whole file using a yamllint, I get no error. I will look into the issue later today.

uroy-personal · 2023-10-03T01:38:30Z

/retest-required

uroy-personal · 2023-10-03T12:41:33Z

Good Morning @kwiesmueller ,
There was some extra space ( line no - 160 ) leading to yamllint validation error. I removed those spaces yesterday night and got the unit test cases passed.
I have also signed the EasyCLA yesterday. Could you please help with the next steps on this PR. Thanks!

uroy-personal · 2023-10-04T12:23:38Z

Hi @jbartosik , @kwiesmueller
I got the EasyCLA step passed. Please approve. Thanks a lot..

kwiesmueller · 2023-10-04T13:17:54Z

/assign maciekpytel smg247

uroy-personal · 2023-10-05T16:13:59Z

Good afternoon @MaciekPytel , @smg247 ,
Request your review on this PR please.

laoj2 · 2023-10-06T18:16:44Z

/lgtm

k8s-ci-robot · 2023-10-06T18:16:49Z

@laoj2: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

laoj2 · 2023-10-06T19:28:47Z

config/testgrids/openshift/redhat-openshift-ocp-release-4.13-informing.yaml

@@ -540,6 +540,33 @@ dashboards:
    results_url_template:
      url: https://prow.ci.openshift.org/job-history/<gcs_prefix>
    test_group_name: periodic-ci-openshift-multiarch-master-nightly-4.13-ocp-e2e-upgrade-aws-ovn-arm64
+  - base_options: width=10&exclude-filter-by-regex=Monitor%5Cscluster&exclude-filter-by-regex=%5Eoperator.Run%20template.*container%20test%24


Can you move the config/testgrids/openshift/... changes to another PR? Those appear to be unrelated to the VPA presubmit tests

Hi @laoj2 ,
I did not add or make any changes to config/testgrids/openshift/. When I raised the PR initially I could only see my changes in a single file. Now I see 3 files got changed as part of this PR.

No idea why config/testgrids/openshift/ changes are pulled in into this PR..

Related to: - kubernetes/k8s.io#5127 Add an ExternelSecret that will sync the kubeconfig for the cluster k8s-infra-kops-prow-build to the k8s-prow cluster. Signed-off-by: Arnaud Meukam <[email protected]>

Signed-off-by: rjsadow <[email protected]>

Kubernetes master

k8s-ci-robot · 2023-10-06T23:01:36Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: uroy-personal
Once this PR has been reviewed and has the lgtm label, please assign zetaab for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

config/jobs/kubernetes/kops/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot · 2023-10-06T23:14:39Z

@uroy-personal: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-test-infra-prow-image-build-test	`ffc4ccb`	link	true	`/test pull-test-infra-prow-image-build-test`
pull-test-infra-integration	`ffc4ccb`	link	true	`/test pull-test-infra-integration`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

uroy-personal · 2023-10-10T02:22:00Z

Good morning @laoj2 ,
While rebasing with the origin, my repository got so many conflicts for some reasons. It was taking too much time to fix for this change. So I deleted my fork and recreated it. This pull request is closed.
I have raised a new one: #30994

Could you please review it.
Thanks.

k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Oct 1, 2023

k8s-ci-robot requested review from bskiba and mwielgus October 1, 2023 23:09

uroy-personal changed the title ~~Allow running e2e tests as presubmits on GitHub #5918~~ Allow running e2e tests as presubmits on GitHub Oct 1, 2023

k8s-ci-robot assigned jbartosik, kgolab and pbetkier Oct 1, 2023

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 2, 2023

k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/testgrid and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 4, 2023

k8s-ci-robot assigned MaciekPytel and smg247 Oct 4, 2023

laoj2 reviewed Oct 6, 2023

View reviewed changes

hongkailiu and others added 6 commits October 6, 2023 16:34

Add logs upon ignoring disabled clusters

a278493

k8s-infra: Add secret for kOps build cluster

b36e534

Related to: - kubernetes/k8s.io#5127 Add an ExternelSecret that will sync the kubeconfig for the cluster k8s-infra-kops-prow-build to the k8s-prow cluster. Signed-off-by: Arnaud Meukam <[email protected]>

migrate sig-autoscaling jobs to community cluster

9aa814e

Signed-off-by: rjsadow <[email protected]>

peribolos: bump ci jobs timeout to 150m

37409a8

split disruptive and serials tests

44d581f

Allow running e2e tests as presubmits on GitHub #5918

ffc4ccb

k8s-ci-robot added area/prow Issues or PRs related to prow area/prow/bump Updates to the k8s prow cluster sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. labels Oct 6, 2023

uroy-personal added 2 commits October 6, 2023 18:08

Rebase with master

90b19c6

Merge pull request #2 from uroy-personal/kubernetes-master

175b482

Kubernetes master

k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 6, 2023

Merge branch 'kubernetes:master' into master

1fbd7a5

uroy-personal closed this by deleting the head repository Oct 10, 2023

uroy-personal mentioned this pull request Oct 10, 2023

Allow running e2e tests as presubmits on GitHub #30994

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Allow running e2e tests as presubmits on GitHub #30927

Allow running e2e tests as presubmits on GitHub #30927

uroy-personal commented Oct 1, 2023

linux-foundation-easycla bot commented Oct 1, 2023 •

edited

Loading

k8s-ci-robot commented Oct 1, 2023

uroy-personal commented Oct 1, 2023

uroy-personal commented Oct 1, 2023

uroy-personal commented Oct 1, 2023

uroy-personal commented Oct 1, 2023

pbetkier commented Oct 2, 2023

kwiesmueller commented Oct 2, 2023

kwiesmueller commented Oct 2, 2023

uroy-personal commented Oct 2, 2023 •

edited

Loading

kwiesmueller commented Oct 2, 2023

uroy-personal commented Oct 2, 2023

uroy-personal commented Oct 2, 2023

umesh-roy-sp commented Oct 2, 2023

uroy-personal commented Oct 3, 2023

uroy-personal commented Oct 3, 2023

uroy-personal commented Oct 4, 2023 •

edited

Loading

kwiesmueller commented Oct 4, 2023

uroy-personal commented Oct 5, 2023

laoj2 commented Oct 6, 2023

k8s-ci-robot commented Oct 6, 2023

laoj2 Oct 6, 2023

uroy-personal Oct 6, 2023

k8s-ci-robot commented Oct 6, 2023

k8s-ci-robot commented Oct 6, 2023 •

edited

Loading

uroy-personal commented Oct 10, 2023

Allow running e2e tests as presubmits on GitHub #30927

Allow running e2e tests as presubmits on GitHub #30927

Conversation

uroy-personal commented Oct 1, 2023

linux-foundation-easycla bot commented Oct 1, 2023 • edited Loading

k8s-ci-robot commented Oct 1, 2023

uroy-personal commented Oct 1, 2023

uroy-personal commented Oct 1, 2023

uroy-personal commented Oct 1, 2023

uroy-personal commented Oct 1, 2023

pbetkier commented Oct 2, 2023

kwiesmueller commented Oct 2, 2023

kwiesmueller commented Oct 2, 2023

uroy-personal commented Oct 2, 2023 • edited Loading

kwiesmueller commented Oct 2, 2023

uroy-personal commented Oct 2, 2023

uroy-personal commented Oct 2, 2023

umesh-roy-sp commented Oct 2, 2023

uroy-personal commented Oct 3, 2023

uroy-personal commented Oct 3, 2023

uroy-personal commented Oct 4, 2023 • edited Loading

kwiesmueller commented Oct 4, 2023

uroy-personal commented Oct 5, 2023

laoj2 commented Oct 6, 2023

k8s-ci-robot commented Oct 6, 2023

laoj2 Oct 6, 2023

Choose a reason for hiding this comment

uroy-personal Oct 6, 2023

Choose a reason for hiding this comment

k8s-ci-robot commented Oct 6, 2023

k8s-ci-robot commented Oct 6, 2023 • edited Loading

uroy-personal commented Oct 10, 2023

linux-foundation-easycla bot commented Oct 1, 2023 •

edited

Loading

uroy-personal commented Oct 2, 2023 •

edited

Loading

uroy-personal commented Oct 4, 2023 •

edited

Loading

k8s-ci-robot commented Oct 6, 2023 •

edited

Loading