Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow running e2e tests as presubmits on GitHub #30994

Merged
merged 2 commits into from
Apr 8, 2024
Merged

Allow running e2e tests as presubmits on GitHub #30994

merged 2 commits into from
Apr 8, 2024

Conversation

uroy-personal
Copy link
Contributor

No description provided.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 10, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @uroy-personal. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config area/jobs sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Oct 10, 2023
@uroy-personal
Copy link
Contributor Author

For the issue : kubernetes/autoscaler#5918

@uroy-personal uroy-personal mentioned this pull request Oct 10, 2023
Closed
@uroy-personal
Copy link
Contributor Author

Good Morning @jbartosik , @kgolab , @pbetkier , @mwielgus & @bskiba.

I had to close the PR : #30927 as my fork got lots of conflicts while rebasing the changes from parent repository. I recreated the fork again and raised this fresh PR.

Please help with approvals for this PR.
Thanks a lot.

@uroy-personal
Copy link
Contributor Author

/retest

@k8s-ci-robot
Copy link
Contributor

@uroy-personal: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kwiesmueller
Copy link
Member

/ok-to-test
/lgtm

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 11, 2023
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 11, 2023
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 12, 2023
@uroy-personal
Copy link
Contributor Author

/retest

@uroy-personal
Copy link
Contributor Author

/lgtm

@k8s-ci-robot
Copy link
Contributor

@uroy-personal: you cannot LGTM your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@uroy-personal
Copy link
Contributor Author

Good Morning @kwiesmueller ,
All clear for this PR. Please help with approval. Thanks.

@kwiesmueller
Copy link
Member

/assign @MaciekPytel

@laoj2
Copy link

laoj2 commented Oct 17, 2023

/lgtm as well.

cc @jbartosik

jbartosik
jbartosik approved these changes Oct 18, 2023
View reviewed changes
Copy link

@jbartosik jbartosik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 18, 2023
@jbartosik
Copy link

@mwielgus please take a look

@k8s-ci-robot
Copy link
Contributor

@laoj2: changing LGTM is restricted to collaborators

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@uroy-personal
Copy link
Contributor Author

Good Morning @mwielgus,
Could you please help with review. Thanks in advace.

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 13, 2024
@uroy-personal
Copy link
Contributor Author

Hi @kwiesmueller ,
Is this PR still relevant? Please advise if it could be merged.

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle rotten
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Mar 22, 2024
@voelzmo
Copy link
Contributor

voelzmo commented Apr 2, 2024

/remove-lifecycle rotten

@k8s-ci-robot k8s-ci-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Apr 2, 2024
mwielgus
mwielgus approved these changes Apr 8, 2024
View reviewed changes
Copy link
Contributor

@mwielgus mwielgus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jbartosik, laoj2, mwielgus, uroy-personal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 8, 2024
@k8s-ci-robot k8s-ci-robot merged commit 134422c into kubernetes:master Apr 8, 2024
6 checks passed
@k8s-ci-robot
Copy link
Contributor

@uroy-personal: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key sig-autoscaling-presubmits.yaml using file config/jobs/kubernetes/sig-autoscaling/sig-autoscaling-presubmits.yaml

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@voelzmo voelzmo mentioned this pull request May 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laoj2 laoj2 laoj2 approved these changes

@mwielgus mwielgus mwielgus approved these changes

@jbartosik jbartosik jbartosik approved these changes

@bskiba bskiba Awaiting requested review from bskiba

Assignees

@jbartosik jbartosik

@MaciekPytel MaciekPytel

@mwielgus mwielgus

@kwiesmueller kwiesmueller

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@uroy-personal @k8s-ci-robot @kwiesmueller @laoj2 @jbartosik @k8s-triage-robot @voelzmo @mwielgus @MaciekPytel