Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bumpity bump upgrade test not parallel #5918

Merged
merged 2 commits into from
Dec 12, 2017
Merged

Bumpity bump upgrade test not parallel #5918

merged 2 commits into from
Dec 12, 2017

Conversation

BenTheElder
Copy link
Member

picks up #5917

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Dec 12, 2017
@BenTheElder
Copy link
Member Author

/lgtm
FYI @krousey

@k8s-ci-robot
Copy link
Contributor

@BenTheElder: you cannot LGTM your own PR.

In response to this:

/lgtm
FYI @krousey

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@BenTheElder BenTheElder added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 12, 2017
@BenTheElder BenTheElder mentioned this pull request Dec 12, 2017
Merged
@BenTheElder
Copy link
Member Author

also FYI @enisoc this hopefully will help with kubernetes/kubernetes#56879

@k8s-ci-robot k8s-ci-robot merged commit f8b0337 into kubernetes:master Dec 12, 2017
@k8s-ci-robot
Copy link
Contributor

@BenTheElder: I updated Prow config for you!

In response to this:

picks up #5917

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@BenTheElder BenTheElder deleted the bumpity-bump-upgrade-test-not-parallel branch December 12, 2017 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krzyzacy krzyzacy Awaiting requested review from krzyzacy

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BenTheElder @k8s-ci-robot