Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

config/jobs: use k8s-triage-robot instead of fejta-bot #22997

Merged
merged 1 commit into from
Jul 23, 2021
Merged

config/jobs: use k8s-triage-robot instead of fejta-bot #22997

merged 1 commit into from
Jul 23, 2021

Conversation

spiffxp
Copy link
Member

@spiffxp spiffxp commented Jul 23, 2021 •
edited
Loading

Fixes: #12296

/hold
For a notice to get sent out (which I can do tomorrow if nobody else wants to)

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 23, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added area/jobs sig/testing Categorizes an issue or PR as relevant to SIG Testing. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jul 23, 2021
@spiffxp spiffxp mentioned this pull request Jul 23, 2021
Closed
@spiffxp
Copy link
Member Author

spiffxp commented Jul 23, 2021

/uncc @chases2 @thockin
/cc @nikhita @cblecker @mrbobbytables

@k8s-ci-robot k8s-ci-robot requested review from cblecker, mrbobbytables and nikhita and removed request for chases2 and thockin July 23, 2021 03:40
@spiffxp
Copy link
Member Author

spiffxp commented Jul 23, 2021

/area github-management
/sig contributor-experience

@k8s-ci-robot k8s-ci-robot added area/github-management Issues or PRs related to GitHub Management subproject sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. labels Jul 23, 2021
nikhita
nikhita reviewed Jul 23, 2021
View reviewed changes
config/jobs/kubernetes/wg-k8s-infra/trusted/sig-contribex-k8s-triage-robot.yaml
- /app/robots/commenter/app.binary
args:
- |-
--query=org:kubernetes
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm also good with this as-is but if we want to do a test run first, we could probably add a new job for triage-robot targeting only specific repos instead of the whole org.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm willing to tackle whatever noise comes from this not working as expected. I'm reasonably confident that #22992 caught all of the issues related to commenting

@spiffxp spiffxp force-pushed the use-k8s-triage-robot-for-commenter-jobs branch from bcf58d0 to 3fd725b Compare July 23, 2021 13:49
@spiffxp
Copy link
Member Author

spiffxp commented Jul 23, 2021

/hold cancel
Notification sent: https://groups.google.com/g/kubernetes-dev/c/oD_ijk7jpa8/m/f24rGVYyAwAJ

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 23, 2021
@dims
Copy link
Member

dims commented Jul 23, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 23, 2021
@k8s-ci-robot k8s-ci-robot merged commit a15e582 into kubernetes:master Jul 23, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone Jul 23, 2021
@k8s-ci-robot
Copy link
Contributor

@spiffxp: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key fejta-bot-periodics.yaml using file ``
  • key sig-contribex-k8s-triage-robot.yaml using file config/jobs/kubernetes/wg-k8s-infra/trusted/sig-contribex-k8s-triage-robot.yaml

In response to this:

Fixes: #11402

/hold
For a notice to get sent out (which I can do tomorrow if nobody else wants to)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spiffxp spiffxp deleted the use-k8s-triage-robot-for-commenter-jobs branch July 23, 2021 15:28
This was referenced Jul 26, 2021
Closed
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikhita nikhita nikhita left review comments

@cblecker cblecker Awaiting requested review from cblecker

@mrbobbytables mrbobbytables Awaiting requested review from mrbobbytables

Assignees

@dims dims

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/github-management Issues or PRs related to GitHub Management subproject area/jobs area/testgrid cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
v1.22
Development

Successfully merging this pull request may close these issues.

Use k8s-triage-robot in lieu of fejta-bot for kubernetes issue/pr commenter jobs
4 participants
@spiffxp @k8s-ci-robot @dims @nikhita