Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Repurpose k8s-merge-robot as k8s-github-robot #11402

Closed
spiffxp opened this issue Feb 20, 2019 · 40 comments
Closed

Repurpose k8s-merge-robot as k8s-github-robot #11402

spiffxp opened this issue Feb 20, 2019 · 40 comments
Assignees
@ameukam @cjwagner @nikhita
Labels
area/github-management Issues or PRs related to GitHub Management subproject kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. sig/testing Categorizes an issue or PR as relevant to SIG Testing.
Milestone
v1.25

Comments

@spiffxp
Copy link
Member

spiffxp commented Feb 20, 2019

What should be cleaned up or changed:
Since we've turned down the submit queue, k8s-merge-robot has sat around basically unused. It has a github token with the same privileges as k8s-ci-robot. Let's use it for automation that manages github configuration, and leave the k8s-ci-robot token for prow's interactions with github related to CI. This will give us some breathing room while we figure out other ways to mitigate our github token usage limits for prow.k8s.io (like using an app instead of personal access token)

Suggest:

  • renaming k8s-merge-robot to k8s-github-robot
  • create a suitable avatar that makes it clear it's the evil twin of k8s-ci-robot
  • use k8s-github-robot's token for utilities such as:
    • peribolos
    • label_sync
    • branch-protector?
    • migratestatus
    • etc.

Provide any links for context:
@spiffxp spiffxp added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Feb 20, 2019
@spiffxp
Copy link
Member Author

spiffxp commented Feb 20, 2019

I've successfully renamed k8s-merge-robot, we now have https://github.com/k8s-github-robot

@spiffxp spiffxp mentioned this issue Feb 20, 2019
Merged
@spiffxp
Copy link
Member Author

spiffxp commented Feb 20, 2019

/sig testing
/sig contributor-experience
/milestone v1.14
/priority important-soon

@k8s-ci-robot k8s-ci-robot added the sig/testing Categorizes an issue or PR as relevant to SIG Testing. label Feb 20, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.14 milestone Feb 20, 2019
@k8s-ci-robot k8s-ci-robot added sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Feb 20, 2019
@stevekuznetsov
Copy link
Contributor

Let's call out status-reconciler specifically?

@stevekuznetsov
Copy link
Contributor

All this SGTM

@spiffxp
Copy link
Member Author

spiffxp commented Feb 21, 2019

I accepted all of the org invites, so at this point k8s-github-robot's token should be good for things. Now to see if it's even in the prow cluster to begin with

@spiffxp
Copy link
Member Author

spiffxp commented Feb 21, 2019

Checking in on label-sync first led me to #11421

Take two...

@nikhita
Copy link
Member

nikhita commented Apr 15, 2019

renaming k8s-merge-robot to k8s-github-robot
create a suitable avatar that makes it clear it's the evil twin of k8s-ci-robot

These are done

use k8s-github-robot's token for utilities such as:

Is this done?

@spiffxp
Copy link
Member Author

spiffxp commented May 7, 2019

/milestone v1.15
/assign @cjwagner
We have talked about this a few times offline. I'm unable to push it forward directly myself. Do we want to take care of this? Should we include this in rate limit experiments mentioned in #12510 ?

@k8s-ci-robot k8s-ci-robot modified the milestones: v1.14, v1.15 May 7, 2019
@cjwagner
Copy link
Member

cjwagner commented May 7, 2019

Yes, lets include k8s-github-robot in the rate limit experiments.
The main thing we need to do to set this up is configure a new ghproxy instance for use with this token. This shouldn't be too much work, but I'm trying to prioritize some other tasks and this is low priority so I'll probably return to this after Kubecon.

@spiffxp
Copy link
Member Author

spiffxp commented Jul 9, 2019

/milestone v1.16
/priority important-longterm

@k8s-ci-robot k8s-ci-robot added the priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. label Jul 9, 2019
@k8s-ci-robot k8s-ci-robot modified the milestones: v1.15, v1.16 Jul 9, 2019
@spiffxp
Copy link
Member Author

spiffxp commented Jul 9, 2019

/remove-priority important-soon

@k8s-ci-robot k8s-ci-robot removed the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Jul 9, 2019
@spiffxp
Copy link
Member Author

spiffxp commented Aug 1, 2019

/area github-management
I think we should change the peribolos jobs to use this token

@k8s-ci-robot k8s-ci-robot added the area/github-management Issues or PRs related to GitHub Management subproject label Aug 1, 2019
@nikhita
Copy link
Member

nikhita commented Aug 12, 2019

The main thing we need to do to set this up is configure a new ghproxy instance for use with this token.

Happy to take this up, once #13683 is merged since it does the same for @k8s-triage-robot.

/assign

@stevekuznetsov
Copy link
Contributor

We're using one ghproxy for two robots, no issue

@spiffxp
Copy link
Member Author

spiffxp commented Oct 15, 2020

I don't have access to secrets in the prow.k8s.io cluster, I will need to see if I can login as k8s-github-robot.

@ameukam
Copy link
Member

ameukam commented Dec 1, 2020

I don't have access to secrets in the prow.k8s.io cluster, I will need to see if I can login as k8s-github-robot.

@spiffxp Any update about this ?

@BenTheElder BenTheElder removed this from the 2020-goals milestone Jan 6, 2021
@BenTheElder
Copy link
Member

2020 is over 🙃

@spiffxp
Copy link
Member Author

spiffxp commented Jan 14, 2021

Having trouble digging up credentials for k8s-github-robot, I'll ping back here when I have more info

@spiffxp spiffxp mentioned this issue Jan 14, 2021
Closed
@spiffxp spiffxp mentioned this issue Jul 22, 2021
Merged
@k8s-triage-robot
Copy link

Manually commenting while logged in as k8s-triage-robot...

@k8s-triage-robot
Copy link

Commenting from local commenter run

@k8s-triage-robot
Copy link

This is a test comment to confirm that k8s-triage-robot can comment on issues

@spiffxp spiffxp mentioned this issue Jul 23, 2021
Merged
@spiffxp
Copy link
Member Author

spiffxp commented Jul 24, 2021 •
edited
Loading

/reopen
Ugh. I've been commenting on the wrong issue this whole time. I deleted my comments here and added them to #12296, but left the k8s-triage-robot comments as proof of testing.

@k8s-ci-robot
Copy link
Contributor

@spiffxp: Reopened this issue.

In response to this:

/reopen
Ugh. I've been commenting on the wrong issue this whole time. Will close the other issue about k8s-triage-robot later

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot reopened this Jul 24, 2021
@spiffxp spiffxp mentioned this issue Jul 26, 2021
Closed
@spiffxp
Copy link
Member Author

spiffxp commented Aug 17, 2021

/milestone v1.23

@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Aug 17, 2021
@BenTheElder BenTheElder modified the milestones: v1.23, someday Apr 19, 2022
@BenTheElder
Copy link
Member

@ameukam where are we at on this?

@ameukam
Copy link
Member

ameukam commented Apr 19, 2022

@BenTheElder we need to migrate the jobs listed in #11402 (comment) to k8s-infra-prow-build-trusted.

/milestone v1.25

@k8s-ci-robot k8s-ci-robot modified the milestones: someday, v1.25 Apr 19, 2022
@MadhavJivrajani
Copy link
Contributor

We should be good to go here, the jobs listed in #11402 (comment) are migrated to the new community clusters as well.

@MadhavJivrajani
Copy link
Contributor

@ameukam please feel free to reopen if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ameukam ameukam

@cjwagner cjwagner

@nikhita nikhita

Labels
area/github-management Issues or PRs related to GitHub Management subproject kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. sig/testing Categorizes an issue or PR as relevant to SIG Testing.
Projects
None yet
Milestone
v1.25
Development

No branches or pull requests
10 participants
@spiffxp @BenTheElder @ameukam @cjwagner @stevekuznetsov @MadhavJivrajani @nikhita @k8s-ci-robot @fejta-bot @k8s-triage-robot