Catch invalid labels earlier #11421
Merged
Catch invalid labels earlier #11421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the code to verify labels was only being run if the --orgs flag was passed. This allowed people to check in invalid labels (description too long) and not find out about it until the first time the label-sync job ran. This change will validate all labels regardless of whether --orgs is passed in, allowing the hack/update-labels.sh script to catch invalid labels. The warning about repos not being in --orgs is only triggered if --orgs is passed in the first place
k8s-ci-robot
added
size/S
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: spiffxp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
k8s-ci-robot
added
area/label_sync
|
/lgtm |
k8s-ci-robot
added
do-not-merge/hold
|
LGTM label has been added. Git tree hash: 03b60ba21b0dcee4b11ede19ee8b5563e41be9b5
|
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the code to verify labels was only being run if
the --orgs flag was passed. This allowed people to check in
invalid labels (description too long) and not find out about
it until the first time the label-sync job ran.
This change will validate all labels regardless of whether
--orgs is passed in, allowing the hack/update-labels.sh
script to catch invalid labels. The warning about repos not
being in --orgs is only triggered if --orgs is passed in
the first place
ref: #11418