-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
config/jobs: fix k8s-triage-robot jobs #23023
config/jobs: fix k8s-triage-robot jobs #23023
Conversation
Catch the mistake I made, where I added jobs to a trusted path, but forgot to add them to the trusted cluster. Old test allowed jobs defined in trusted paths to run on any cluster. New test verifies jobs defined in trusted paths must run on trusted cluster, jobs defined anywhere else cannot run on trusted cluster
Most of them are failing to find their secret because they're running in the wrong cluster
/uncc @thockin @wojtek-t |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dims, spiffxp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@spiffxp: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Most of them are failing to find their secret because they're running in the wrong cluster. Added a test to catch my mistake and then fixed the job configs.
Followup to #22997
Part of #12296