Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config/jobs: fix k8s-triage-robot jobs #23023

Merged

Conversation

spiffxp
Copy link
Member

@spiffxp spiffxp commented Jul 26, 2021

Most of them are failing to find their secret because they're running in the wrong cluster. Added a test to catch my mistake and then fixed the job configs.

Followup to #22997

Part of #12296

Catch the mistake I made, where I added jobs to a trusted path, but
forgot to add them to the trusted cluster.

Old test allowed jobs defined in trusted paths to run on any cluster.

New test verifies jobs defined in trusted paths must run on trusted
cluster, jobs defined anywhere else cannot run on trusted cluster
Most of them are failing to find their secret because they're running in
the wrong cluster
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 26, 2021
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. area/config Issues or PRs related to code in /config sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jul 26, 2021
@spiffxp
Copy link
Member Author

spiffxp commented Jul 26, 2021

@k8s-ci-robot k8s-ci-robot requested review from cblecker, mrbobbytables and nikhita and removed request for thockin and wojtek-t July 26, 2021 17:47
@dims
Copy link
Member

dims commented Jul 26, 2021

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 26, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 17297ac into kubernetes:master Jul 26, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone Jul 26, 2021
@k8s-ci-robot
Copy link
Contributor

@spiffxp: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key sig-contribex-k8s-triage-robot.yaml using file config/jobs/kubernetes/wg-k8s-infra/trusted/sig-contribex-k8s-triage-robot.yaml

In response to this:

Most of them are failing to find their secret because they're running in the wrong cluster. Added a test to catch my mistake and then fixed the job configs.

Followup to #22997

Part of #12296

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spiffxp spiffxp deleted the fix-k8s-triage-robot-jobs-cluster branch July 26, 2021 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants