Update capd presubmit job definition

[ashish-amarnath]

Signed-off-by: Ashish Amarnath [email protected]

/assign @chuckha

• switch to an image with docker binaries
• start the docker daemon prior to starting verify-all.sh

I think this should allow us to run docker in docker. Need to confirm runner.sh starts the docker daemon.

[k8s-ci-robot]

Hi @ashish-amarnath. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[ashish-amarnath]

Stolen from https://github.com/kubernetes/test-infra/blob/master/config/jobs/kubernetes-sigs/cluster-api-provider-aws/cluster-api-provider-aws-presubmits.yaml#L42-L44

[BenTheElder]

FYI this will track what versions of tools test-infra has, versus what version of tools kubernetes/kubernetes has on the master branch

that may be what you want, but just a heads up there. these images are regularly updated.

[Katharine]

This is very likely not what you want, and may lead to us breaking you at any time. Why do you want experimental?

[ashish-amarnath]

This was copied from another job. Do you have an alternate tag that you would like me to use?

[ashish-amarnath]

The reason for the image name change is to be able to use docker in docker. So we need docker binaries built into the image.

[Katharine]

master should have docker binaries in it already:

ktbry@ktbry2 ~> docker run --rm -it --entrypoint /bin/bash gcr.io/k8s-testimages/kubekins-e2e:v20190703-1f4d616-master
root@599eae9b66f7:/workspace# docker version
Client:
 Version:           18.09.6
 API version:       1.39
 Go version:        go1.10.8
 Git commit:        481bc77
 Built:             Sat May  4 02:36:00 2019
 OS/Arch:           linux/amd64
 Experimental:      false

[ashish-amarnath]

I might have done something wrong. Thanks for checking this for me :)
I've reverted the image name change. PTAL

[BenTheElder]

Needs the preset-dind-enabled 😅

[chuckha]

/ok-to-test

[BenTheElder]

looks right to me 👍

[chuckha]

/lgtm

please reassign if you are busy! i've just interacted with you the most here

/assign @Katharine

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: 507f1337b5e3f8eb956f5aaff2e5f90b57405e8b

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: ab27ec466d6cc7bce5bf94b4e5b046bbca348a4b

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ashish-amarnath, Katharine

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• config/jobs/kubernetes-sigs/cluster-api-provider-docker/OWNERS [Katharine]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ashish-amarnath]

/test pull-test-infra-bazel

[k8s-ci-robot]

@ashish-amarnath: Updated the job-config configmap in namespace default using the following files:

• key cluster-api-provider-docker-presubmits.yaml using file config/jobs/kubernetes-sigs/cluster-api-provider-docker/cluster-api-provider-docker-presubmits.yaml

In response to this:

Signed-off-by: Ashish Amarnath [email protected]

/assign @chuckha

• switch to an image with docker binaries
• start the docker daemon prior to starting verify-all.sh

I think this should allow us to run docker in docker. Need to confirm runner.sh starts the docker daemon.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.