Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update capd presubmit job definition #13366

Merged
merged 4 commits into from
Jul 10, 2019
Merged

Update capd presubmit job definition #13366

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fea0c32
update capd presubmit job definition
ashish-amarnath Jul 9, 2019
655e768
set preset-dind-enabled
ashish-amarnath Jul 9, 2019
f3785d1
Merge branch 'master' into update-capd-presubmit
ashish-amarnath Jul 10, 2019
24358a7
revert image name change
ashish-amarnath Jul 10, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion ...s/kubernetes-sigs/cluster-api-provider-docker/cluster-api-provider-docker-presubmits.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,10 @@ presubmits:
decorate: true
spec:
containers:
- image: gcr.io/k8s-testimages/kubekins-e2e:v20190703-1f4d616-master
- image: gcr.io/k8s-testimages/kubekins-e2e:v20190703-1f4d616-experimental
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stolen from https://github.com/kubernetes/test-infra/blob/master/config/jobs/kubernetes-sigs/cluster-api-provider-aws/cluster-api-provider-aws-presubmits.yaml#L42-L44

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI this will track what versions of tools test-infra has, versus what version of tools kubernetes/kubernetes has on the master branch

that may be what you want, but just a heads up there. these images are regularly updated.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is very likely not what you want, and may lead to us breaking you at any time. Why do you want experimental?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was copied from another job. Do you have an alternate tag that you would like me to use?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reason for the image name change is to be able to use docker in docker. So we need docker binaries built into the image.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

master should have docker binaries in it already:

ktbry@ktbry2 ~> docker run --rm -it --entrypoint /bin/bash gcr.io/k8s-testimages/kubekins-e2e:v20190703-1f4d616-master
root@599eae9b66f7:/workspace# docker version
Client:
 Version:           18.09.6
 API version:       1.39
 Go version:        go1.10.8
 Git commit:        481bc77
 Built:             Sat May  4 02:36:00 2019
 OS/Arch:           linux/amd64
 Experimental:      false

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might have done something wrong. Thanks for checking this for me :)
I've reverted the image name change. PTAL

command:
- "runner.sh"
- "./hack/verify-all.sh"
# docker-in-docker needs privileged mode
securityContext:
privileged: true