This repository has been archived by the owner on Sep 24, 2021. It is now read-only.
Add verify-docker-build to pre-submit tests #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/M
Signed-off-by: Ashish Amarnath <[email protected]>
ashish-amarnath
force-pushed
the
verify-docker-build
branch
from
c4f5263 to
c8e1c94
Compare
ashish-amarnath
changed the title
k8s-ci-robot
added
the
do-not-merge/work-in-progress
|
We need docker in docker enabled for the pre-submit job to be able to do this |
|
kubernetes/test-infra#13366 should update the pre-submit job config. |
chuckha
reviewed
Jul 9, 2019
Signed-off-by: Ashish Amarnath <[email protected]>
ashish-amarnath
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
|
/approve thanks ! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ashish-amarnath, chuckha The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/lgtm |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
To ensure an image for
capd-managercan be built with the proposed changes in a PRWhich issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #60
Special notes for your reviewer:
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
Release note: