Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop enabling alpha admission API in non-alpha PR job against 1.14 #11851

Merged
merged 1 commit into from
Mar 20, 2019
Merged

Stop enabling alpha admission API in non-alpha PR job against 1.14 #11851

merged 1 commit into from
Mar 20, 2019

Conversation

spiffxp
Copy link
Member

@spiffxp spiffxp commented Mar 20, 2019

Followup to #10795

Apparently when we added 1.14 jobs we copied from 1.13 rather than from master?

Fixes #11850

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Mar 20, 2019
@spiffxp spiffxp changed the title Stop enabling alph admission API in non-alpha PR job against 1.14 Stop enabling alpha admission API in non-alpha PR job against 1.14 Mar 20, 2019
@neolit123
Copy link
Member

neolit123 commented Mar 20, 2019 •
edited
Loading

/lgtm
i think it needs a ./hack/update-config.sh

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 20, 2019
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 4f12b9d75b58c255675c3808d514b7c469e70b43

@liggitt
Copy link
Member

liggitt commented Mar 20, 2019

hack/update-config.sh? lgtm otherwise

@spiffxp spiffxp force-pushed the 1.14-alpha-admission-fixup branch from edd558c to 171b7e4 Compare March 20, 2019 15:54
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 20, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@spiffxp spiffxp mentioned this pull request Mar 20, 2019
Merged
@liggitt
Copy link
Member

liggitt commented Mar 20, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 20, 2019
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 74118d57554953be652551cd0e0f54618c43144c

@k8s-ci-robot k8s-ci-robot merged commit 83a1bd4 into kubernetes:master Mar 20, 2019
@k8s-ci-robot
Copy link
Contributor

@spiffxp: Updated the job-config configmap in namespace default using the following files:

  • key generated-security-jobs.yaml using file config/jobs/kubernetes-security/generated-security-jobs.yaml
  • key sig-gcp-gce-config.yaml using file config/jobs/kubernetes/sig-gcp/sig-gcp-gce-config.yaml

In response to this:

Followup to #10795

Apparently when we added 1.14 jobs we copied from 1.13 rather than from master?

Fixes #11850

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spiffxp spiffxp deleted the 1.14-alpha-admission-fixup branch April 19, 2019 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abgworrall abgworrall Awaiting requested review from abgworrall

@dashpole dashpole Awaiting requested review from dashpole

Assignees

@neolit123 neolit123

@liggitt liggitt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@spiffxp @neolit123 @k8s-ci-robot @liggitt