Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make hack/verify-config.sh output nicer to humans #11852

Merged

Conversation

spiffxp
Copy link
Member

@spiffxp spiffxp commented Mar 20, 2019

The exit code from diff was preventing me from seeing the
human firendly "please run" instructions

Dropped xtrace because not many of our verify scripts use it

Encountered in #11851

The exit code from diff was preventing me from seeing the
human firendly "please run" instructions

Dropped xtrace because not many of our verify scripts use it
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 20, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 20, 2019
@k8s-ci-robot k8s-ci-robot requested review from fejta and ixdy March 20, 2019 16:06
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Mar 20, 2019
@spiffxp
Copy link
Member Author

spiffxp commented Mar 20, 2019

/uncc @ixdy
/cc @krzyzacy

@k8s-ci-robot k8s-ci-robot requested review from krzyzacy and removed request for ixdy March 20, 2019 16:11
@Katharine
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 20, 2019
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 78389ad59ca25940d61a1e202e03ef5289183763

@k8s-ci-robot k8s-ci-robot merged commit 8637f12 into kubernetes:master Mar 20, 2019
@spiffxp spiffxp deleted the show-verify-config-fail-output branch March 20, 2019 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants