Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GCE/GCP job presets use deprecated GV "admissionregistration.k8s.io/v1alpha1" #11850

Closed
neolit123 opened this issue Mar 20, 2019 · 3 comments
Closed

GCE/GCP job presets use deprecated GV "admissionregistration.k8s.io/v1alpha1" #11850

neolit123 opened this issue Mar 20, 2019 · 3 comments
Assignees
@spiffxp @liggitt
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now.

Comments

@neolit123
Copy link
Member

neolit123 commented Mar 20, 2019 •
edited
Loading

in the release 1.14 change log we have:
https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG-1.14.md

The alpha Initializers feature, admissionregistration.k8s.io/v1alpha1 API version, Initializers admission plugin, and use of the metadata.initializers API field have been removed. Discontinue use of the alpha feature and delete any existing InitializerConfiguration API objects before upgrading. The metadata.initializers field will be removed in a future release. (#72972, @liggitt)

GCE jobs such as pull-kubernetes-e2e-gce still use:
admissionregistration.k8s.io/v1alpha1

https://github.com/kubernetes/test-infra/blob/master/config/jobs/kubernetes/sig-gcp/sig-gcp-gce-config.yaml#L209

all jobs that use this GCE/GCP preset will pass admissionregistration.k8s.io/v1alpha1=true to the --runtime flag of the api-server and will fail in the 1.14 branch.

e.g.:
https://storage.googleapis.com/kubernetes-jenkins/pr-logs/pull/75489/pull-kubernetes-e2e-gce/72987/artifacts/e2e-72987-674b9-master/kube-apiserver.log

/assign @liggitt @spiffxp
cc @hoegaarden
@neolit123 neolit123 added the kind/bug Categorizes issue or PR as related to a bug. label Mar 20, 2019
@neolit123
Copy link
Member Author

/priority critical-urgent

@k8s-ci-robot k8s-ci-robot added the priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. label Mar 20, 2019
@neolit123 neolit123 mentioned this issue Mar 20, 2019
Merged
@spiffxp
Copy link
Member

spiffxp commented Mar 20, 2019

#10795 was apparently supposed to catch this, looking...

@liggitt
Copy link
Member

liggitt commented Mar 20, 2019

looks like b68f001#diff-c8e02b4dec1c4ef0c36b616538d00bb6 just copied 1.13-level job config into 1.14, instead of using the current master config that was fixed in #10795

@spiffxp spiffxp mentioned this issue Mar 20, 2019
Merged
@spiffxp spiffxp mentioned this issue Mar 20, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@spiffxp spiffxp

@liggitt liggitt

Labels
kind/bug Categorizes issue or PR as related to a bug. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@spiffxp @neolit123 @liggitt @k8s-ci-robot