Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify who has website write access and why #1375

Merged
merged 1 commit into from
Nov 20, 2019
Merged

Clarify who has website write access and why #1375

merged 1 commit into from
Nov 20, 2019

Conversation

zacharysarah
Copy link

@zacharysarah zacharysarah commented Nov 2, 2019 •
edited
Loading

Based on this #sig-release Slack discussion, this PR changes the team name of sig-docs-l10n-admins to kubernetes-website-write and adds comments for why each team member has write access.

This PR also freshens team membership to the current SIG Docs chairs.

Many thanks to @justaugustus for the guidance!

/sig docs

@k8s-ci-robot k8s-ci-robot added sig/docs Categorizes an issue or PR as relevant to SIG Docs. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 2, 2019
@zacharysarah
Copy link
Author

@jimangel Once this merges, we can start adding release leads (@daminisatya) to kubernetes-website-write to give them the permissions they need.

@daminisatya
Copy link
Contributor

+1 Thank you @zacharysarah

@justaugustus
Copy link
Member

Awesome. Thanks for adding these clarifications to the group name, @zacharysarah!
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 2, 2019
@justaugustus
Copy link
Member

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 2, 2019
justaugustus
justaugustus suggested changes Nov 2, 2019
View reviewed changes
Copy link
Member

@justaugustus justaugustus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zacharysarah -- Actually, one small nit. Looks like we're using the following nomenclature in other places, like kubernetes-sigs/:

  • <repo>-admins - admin access to <repo>
  • <repo>-write - write access to <repo>

Examples:

org/config/kubernetes-sigs/sig-release/teams.yaml

Lines 22 to 23 in 06745b2

release-notes-admins:
description: admin access to release-notes

org/config/kubernetes-sigs/sig-release/teams.yaml

Lines 29 to 30 in 06745b2

release-notes-maintainers:
description: write access to release-notes

Would you mind changing the name to website-maintainers and alpha-sorting the list?

config/kubernetes/sig-docs/teams.yaml Outdated Show resolved Hide resolved
@justaugustus
Copy link
Member

justaugustus commented Nov 2, 2019 •
edited
Loading

Oh, one more thing!

You could also move the admins team

org/config/kubernetes/org.yaml

Line 1726 in 06745b2

kubernetes-website-admins:

into the SIG Docs directory and rename to website-admins.

This will give y'all access to approve changes there without having to flag a config/kubernetes/ approver. :)

@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 4, 2019
@zacharysarah
Copy link
Author

@justaugustus 👋 Feedback incorporated, PTAL

justaugustus
justaugustus suggested changes Nov 4, 2019
View reviewed changes
Copy link
Member

@justaugustus justaugustus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zacharysarah -- two more tiny nits!

config/kubernetes/sig-docs/teams.yaml Outdated
privacy: closed
sig-docs-vi-reviews:
description: PR reviews for Vietnamese content
website-write:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
website-write:
website-maintainers:

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll need to place the renamed team above website-milestone-maintainers list as well.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the list not be alphabetical? Because right now teams are in alphabetical order:

309: website-admins
316: website-milestone-maintainers
372: website-write

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This still needs to be website-maintainers instead of website-write.

config/kubernetes/sig-docs/teams.yaml Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 18, 2019
@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 18, 2019
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 18, 2019
@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Nov 18, 2019
@justaugustus
Copy link
Member

/assign @cblecker @mrbobbytables

nikhita
nikhita reviewed Nov 18, 2019
View reviewed changes
config/kubernetes/sig-docs/teams.yaml Outdated Show resolved Hide resolved
config/kubernetes/sig-docs/teams.yaml Outdated
privacy: closed
sig-docs-vi-reviews:
description: PR reviews for Vietnamese content
website-write:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This still needs to be website-maintainers instead of website-write.

config/kubernetes/sig-docs/teams.yaml Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 18, 2019
@justaugustus
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 18, 2019
@cblecker
Copy link
Member

Needs rebase

Clarify who has website write access and why,
b976224 
consolidate all access into sig-docs/teams.yaml
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 20, 2019
@zacharysarah zacharysarah mentioned this pull request Nov 20, 2019
Merged
@zacharysarah
Copy link
Author

@cblecker Done!

@justaugustus Ping, looks like @cblecker is busy.

@zacharysarah zacharysarah mentioned this pull request Nov 20, 2019
Merged
@cblecker
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 20, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, justaugustus, zacharysarah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 20, 2019
@k8s-ci-robot k8s-ci-robot merged commit 8c9c10e into kubernetes:master Nov 20, 2019
huynguyennovem pushed a commit to huynguyennovem/org that referenced this pull request Nov 21, 2019
@k8s-ci-robot @huynguyennovem
Merge pull request kubernetes#1375 from zacharysarah/website-write
1ae64c4 
Clarify who has website write access and why

Signed-off-by: huynguyennovem <[email protected]>
@rlenferink rlenferink mentioned this pull request Nov 21, 2019
Closed
@xichengliudui xichengliudui mentioned this pull request Nov 30, 2019
Merged
@zacharysarah zacharysarah deleted the website-write branch December 4, 2019 23:45
@sftim sftim mentioned this pull request Jan 13, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikhita nikhita nikhita left review comments

@justaugustus justaugustus justaugustus requested changes

@Bradamant3 Bradamant3 Awaiting requested review from Bradamant3

@jimangel jimangel Awaiting requested review from jimangel

Assignees

@justaugustus justaugustus

@cblecker cblecker

@mrbobbytables mrbobbytables

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@zacharysarah @daminisatya @justaugustus @cblecker @k8s-ci-robot @nikhita @mrbobbytables