Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding sig-docs-vi members #1431

Merged
merged 1 commit into from
Dec 5, 2019
Merged

Adding sig-docs-vi members #1431

merged 1 commit into from
Dec 5, 2019

Conversation

huynguyennovem
Copy link
Member

Add new owner and reviewer for the Vietnamese translation team

Signed-off-by: Nguyen Quang Huy [email protected]

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 20, 2019
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Nov 20, 2019
@truongnh1992
Copy link
Member

/lgtm
@huynguyennovem joined the owners and reviewers for the Vietnamese translation team at kubernetes/website#17653

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 20, 2019
@zacharysarah
Copy link

@huynguyennovem Please wait for #1375 to merge, then rebase this PR and add members to website-maintainers instead of to sig-docs-l10n-admins.

@zacharysarah
Copy link

/assign @jimangel @Bradamant3

@k8s-ci-robot @huynguyennovem
Merge pull request kubernetes#1375 from zacharysarah/website-write
1ae64c4 
Clarify who has website write access and why

Signed-off-by: huynguyennovem <[email protected]>
@huynguyennovem huynguyennovem force-pushed the sig-docs-add-vi-members branch from b809268 to 1ae64c4 Compare November 21, 2019 02:47
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 21, 2019
@huynguyennovem
Copy link
Member Author

@huynguyennovem Please wait for #1375 to merge, then rebase this PR and add members to website-maintainers instead of to sig-docs-l10n-admins.

Yes, I have done this.

@truongnh1992
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 21, 2019
@zacharysarah
Copy link

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: huynguyennovem, zacharysarah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 4, 2019
@k8s-ci-robot k8s-ci-robot merged commit 7e5fa0b into kubernetes:master Dec 5, 2019
@truongnh1992 truongnh1992 mentioned this pull request Dec 23, 2019
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jimangel jimangel Awaiting requested review from jimangel

@zacharysarah zacharysarah Awaiting requested review from zacharysarah

Assignees

@zacharysarah zacharysarah

@jimangel jimangel

@Bradamant3 Bradamant3

@truongnh1992 truongnh1992

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@huynguyennovem @truongnh1992 @zacharysarah @k8s-ci-robot @jimangel @Bradamant3