Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sig-docs-ru members #1433

Merged
merged 1 commit into from
Dec 4, 2019
Merged

Add sig-docs-ru members #1433

merged 1 commit into from
Dec 4, 2019

Conversation

Potapy4
Copy link

@Potapy4 Potapy4 commented Nov 20, 2019 •
edited
Loading

Add owners and reviewers for RU transaltion team.

Related to kubernetes/website#16404

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Nov 20, 2019
@Potapy4
Copy link
Author

Potapy4 commented Nov 20, 2019

/assign @zacharysarah

@Potapy4 Potapy4 changed the title Add RU owners and reviewers Add sig-docs-ru members Nov 20, 2019
@zacharysarah
Copy link

@Potapy4 Thanks for making these updates. Please wait for #1375 to merge, then add folks to website-maintainers instead of sig-docs-l10n-admins. Otherwise LGTM

/approve
/hold
/assign @jimangel @Bradamant3

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 20, 2019
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 20, 2019
@Potapy4
Copy link
Author

Potapy4 commented Nov 21, 2019

@Potapy4 Thanks for making these updates. Please wait for #1375 to merge, then add folks to website-maintainers instead of sig-docs-l10n-admins. Otherwise LGTM

/approve
/hold
/assign @jimangel @Bradamant3

Ready 🙂

@sftim
Copy link
Contributor

sftim commented Nov 22, 2019

Not sure when it's OK to unhold this one.

@zacharysarah
Copy link

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 4, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Potapy4, zacharysarah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zacharysarah
Copy link

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 4, 2019
@k8s-ci-robot k8s-ci-robot merged commit f7ef292 into kubernetes:master Dec 4, 2019
@Potapy4 Potapy4 deleted the sig-docs-ru-members branch December 5, 2019 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jimangel jimangel Awaiting requested review from jimangel

@zacharysarah zacharysarah Awaiting requested review from zacharysarah

Assignees

@zacharysarah zacharysarah

@jimangel jimangel

@Bradamant3 Bradamant3

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Potapy4 @zacharysarah @sftim @k8s-ci-robot @jimangel @Bradamant3