-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement WarmPool on Terraform #11633
Comments
I am new to this project and would love to help in implementing this feature. Can you guide me a little? @johngmyers |
The task is to implement I would suggest looking at other Adding an integration test for warmpool would also be good. The integration tests are in kops/cmd/kops/integration_test.go. |
It looks like Terraform puts this inside the ASG definition, so you'll probably have to put this in |
/assign |
/assign |
If others are not working on the task I'd like to look into it now, so am assigning myself. |
/assign @JacekDuszenko |
The WarmPool task has an AutoScalingGroup reference field yet doesn't use it in any of its methods, I'm assuming this is for dependency purposes @olemarkus ? We likely can't add a WarmPool task reference in the ASG task because of the dependency loop, so we may need to wait for hashicorp/terraform-provider-aws#19229 unless anyone has other ideas on how this could be implemented. |
I believe for the Terraform target, the The trick would then be to keep the warmpool config in the |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
Seems like this PR addressed this issue. |
@SD-13: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
1. Describe IN DETAIL the feature/behavior/change you would like to see.
Implement
WarmPool.RenderTerraform()
2. Feel free to provide a design supporting your feature request.
/kind feature
/area terraform
/lifecycle frozen
The text was updated successfully, but these errors were encountered: