-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add terraform target support for configuring Warm Pool #15153
Conversation
Welcome @rsafonseca! |
Hi @rsafonseca. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Seems like CLA site is currently broken, i've opened a support ticket with them so I can get that check fixed on this PR :) |
/ok-to-test |
/lgtm from what I can tell |
/lgtm |
Looks good to me also. Thanks @rsafonseca! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hakman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@hakman can we also get this backported into current supported branches? I can do some PRs for each minor if needed :) |
Done for 1.26 and 1.25. Let's see what @olemarkus thinks about it. |
…-upstream-release-1.26 Automated cherry pick of #15153: Add terraform target support for configuring Warm Pool
Awesome! Thanks for the speedy turnaround in this :D |
Happy to help. Would say 1-2 weeks max. |
…-upstream-release-1.25 Automated cherry pick of #15153: Add terraform target support for configuring Warm Pool
…-of-#15153-upstream-release-1.26 Automated cherry pick of kubernetes#15153: Add terraform target support for configuring Warm Pool
Addresses #11633