Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate resource for aws_autoscaling_warm_pool from aws_autoscaling_group #19229

Closed
nitrocode opened this issue May 4, 2021 · 2 comments
Closed
Labels
enhancement Requests to existing resources that expand the functionality or scope. new-resource Introduces a new resource. service/autoscaling Issues and PRs that pertain to the autoscaling service. stale Old or inactive issues managed by automation, if no further action taken these will get closed.

Comments

@nitrocode
Copy link
Contributor

nitrocode commented May 4, 2021

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

It would be nice if I can add a warm pool to an existing asg without having to update the existing asg resource. For instance, for aws_autoscaling_group I can add a lifecycle hook in-line using the input initial_lifecycle_hook or I can add the hook using the separate resource aws_autoscaling_lifecycle_hook.

I'd like to do the same with an aws_autoscaling_group and aws_autoscaling_warm_pool.

It's also a separate action in both cloudformation AWS::AutoScaling::WarmPool and in the aws autoscaling put-warm-pool so a separate resource in addition to the in-line method would be consistent.

New or Affected Resource(s)

  • aws_autoscaling_warm_pool

Potential Terraform Configuration

resource "aws_autoscaling_warm_pool" "example" {
  autoscaling_group_name = aws_autoscaling_group.example.id
  pool_state             = "Stopped"
  min_size               = 4
}

References

cc: @ewbankkit, @akshayjain1996

@nitrocode nitrocode added the enhancement Requests to existing resources that expand the functionality or scope. label May 4, 2021
@ghost ghost added the service/autoscaling Issues and PRs that pertain to the autoscaling service. label May 4, 2021
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label May 4, 2021
@anGie44 anGie44 added new-resource Introduces a new resource. and removed needs-triage Waiting for first response or review from a maintainer. labels May 4, 2021
@github-actions
Copy link

Marking this issue as stale due to inactivity. This helps our maintainers find and focus on the active issues. If this issue receives no comments in the next 30 days it will automatically be closed. Maintainers can also remove the stale label.

If this issue was automatically closed and you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thank you!

@github-actions github-actions bot added the stale Old or inactive issues managed by automation, if no further action taken these will get closed. label Apr 24, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale May 24, 2023
@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. new-resource Introduces a new resource. service/autoscaling Issues and PRs that pertain to the autoscaling service. stale Old or inactive issues managed by automation, if no further action taken these will get closed.
Projects
None yet
Development

No branches or pull requests

2 participants