Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update kep/sig-cli/0031-kustomize-integration #680

Merged
merged 1 commit into from
Jan 10, 2019
Merged

update kep/sig-cli/0031-kustomize-integration #680

merged 1 commit into from
Jan 10, 2019

Conversation

Liujingfang1
Copy link
Contributor

@Liujingfang1 Liujingfang1 commented Jan 7, 2019 •
edited
Loading

Update the kep to include:

  • change status to valid one
  • remove TODO item since it's done

To view the KEP, click here

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 7, 2019
@Liujingfang1
Copy link
Contributor Author

/cc @seans3 @pwittrock @soltysh

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/pm labels Jan 7, 2019
@Liujingfang1 Liujingfang1 force-pushed the kustomize branch 3 times, most recently from 0941b55 to 8d93cf2 Compare January 7, 2019 21:40
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 7, 2019
@Liujingfang1 Liujingfang1 force-pushed the kustomize branch 4 times, most recently from 0bb9083 to e03cd85 Compare January 8, 2019 00:21
bgrant0607
bgrant0607 reviewed Jan 9, 2019
View reviewed changes
keps/sig-cli/0031-kustomize-integration.md Outdated
last-updated: yyyy-mm-dd
status: pending
last-updated: 2019-01-07
status: implementable
see-also:
- [KEP-0008](https://github.com/kubernetes/community/blob/master/keps/sig-cli/0008-kustomize.md)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See PR #664 -- this line apparently prevents the table from rendering properly

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed it. Thank you.

@philoserf philoserf mentioned this pull request Jan 9, 2019
Closed
@pwittrock
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 10, 2019
@pwittrock
Copy link
Member

I am going to add some more background to this for future readers, but want to merge your updates first.

@pwittrock
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Liujingfang1, pwittrock

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 1493802 into kubernetes:master Jan 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bgrant0607 bgrant0607 bgrant0607 left review comments

@pwittrock pwittrock Awaiting requested review from pwittrock

@seans3 seans3 Awaiting requested review from seans3

@soltysh soltysh Awaiting requested review from soltysh

Assignees

@pwittrock pwittrock

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/cli Categorizes an issue or PR as relevant to SIG CLI. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Liujingfang1 @pwittrock @k8s-ci-robot @bgrant0607 @justaugustus