Skip to content

Commit

Permalink
Merge pull request #680 from Liujingfang1/kustomize
Browse files Browse the repository at this point in the history
update kep/sig-cli/0031-kustomize-integration
  • Loading branch information
k8s-ci-robot authored Jan 10, 2019
2 parents 03a260a + 1451bc3 commit 1493802
Showing 1 changed file with 13 additions and 13 deletions.
26 changes: 13 additions & 13 deletions keps/sig-cli/0031-kustomize-integration.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,10 @@ approvers:
- "@soltysh"
editor: TBD
creation-date: 2018-11-07
last-updated: yyyy-mm-dd
status: pending
last-updated: 2019-01-07
status: implementable
see-also:
- [KEP-0008](https://github.com/kubernetes/community/blob/master/keps/sig-cli/0008-kustomize.md)
- "[KEP-0008](https://github.com/kubernetes/community/blob/master/keps/sig-cli/0008-kustomize.md)"
replaces:
- n/a
superseded-by:
Expand Down Expand Up @@ -49,7 +49,7 @@ superseded-by:
[Tools for generating]: https://github.com/ekalinin/github-markdown-toc

## Summary
[Kustomize](https://github.com/kubernetes-sigs/kustomize) is a tool developed to provide declarative support for kubernetes objects. It has been adopted by many projects and users. Having kustomize enabled in kubectl will address a list of long standing issues. This KEP describes how `kustomize` is integrated into kubectl subcommands with consistent UX.
[Kustomize](https://github.com/kubernetes-sigs/kustomize) was developed as a distinct tool from kubectl to rapidly experiment on declarative configuration. The code was developed to solve some long standing, complex kubectl [issues](https://github.com/kubernetes/enhancements/blob/master/keps/sig-cli/0008-kustomize.md#long-standing-issues). The final step is to close the issues by bringing the code into kubectl. This KEP describes how to do this with consistent kubectl UX.

## Motivation

Expand Down Expand Up @@ -98,9 +98,8 @@ Kustomize has following subcommands:
- Resolve variables and substitute them

```
# TODO: currently kustomization.yaml is not versioned
# Need to version this with apiVersion and Kind
# https://github.com/kubernetes-sigs/kustomize/issues/588
apiVersion: v1beta1
kind: Kustomization
namePrefix: alices-
commonAnnotations:
Expand Down Expand Up @@ -197,14 +196,15 @@ There are two signals that can indicate the success of this integration.

Most implementation will be in cli-runtime

- vendor `kustomize/pkg` into kubernetes
- copy `kustomize/k8sdeps` into cli-runtime
- Implement a Visitor for kustomization directory which
- [x] vendor `kustomize/pkg` into kubernetes
- [x] copy `kustomize/k8sdeps` into cli-runtime
- [x] Implement a Visitor for kustomization directory which
- execute kustomize build to get a list of resources
- write the output to a StreamVisitor
- When parsing filename parameters in FilenameParam, look for kustomization directories
- update the examples in kubectl commands
- Improve help messages or documentations to list kubectl subcommands that can work with kustomization directories
- [x] When parsing filename parameters in FilenameParam, look for kustomization directories
- [ ] documentation:
- update the examples in kubectl commands
- Improve help messages or documentations to list kubectl subcommands that can work with kustomization directories

## Alternatives

Expand Down

0 comments on commit 1493802

Please sign in to comment.