Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 0031-kustomize-integration.md #682

Closed
wants to merge 1 commit into from
Closed

Update 0031-kustomize-integration.md #682

wants to merge 1 commit into from

Conversation

philoserf
Copy link

@philoserf philoserf commented Jan 9, 2019

- fix YAML front matter parsing by quoting the embedded markdown of `see-also:`.
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: philoserf
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: pwittrock

If they are not already assigned, you can assign the PR to them by writing /assign @pwittrock in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/pm size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 9, 2019
@k8s-ci-robot k8s-ci-robot requested review from seans3 and soltysh January 9, 2019 02:38
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 9, 2019
@mattfarina
Copy link
Contributor

Is this the table part this was supposed to fix? The left is the tip of master and the right is the code for the fix. I don't see a difference. Am I missing something?

screen shot 2019-01-15 at 10 52 23 am

@philoserf
Copy link
Author

Fixed in another PR #664.

@philoserf philoserf closed this Jan 15, 2019
@philoserf philoserf deleted the patch-1 branch January 15, 2019 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/cli Categorizes an issue or PR as relevant to SIG CLI. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants