Add GetAllocatableResource to PodResource API #2404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
Hi @fromanirh. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
needs-ok-to-test
k8s-ci-robot
added
kind/kep
4 tasks
|
rationale for this split in this slack conversation the main goal is to make this change easier to review |
swatisehgal
reviewed
Feb 2, 2021
|
this will need a /prod-readiness file change as well so it gets assigned a prr reviewer. |
ffromani
commented
Feb 2, 2021
keps/sig-node/2403-pod-resources-allocatable-resources/README.md
Outdated
Show resolved
Hide resolved
ffromani
force-pushed
the
podresources-get-alloctable-resources
branch
from
d3de0da to
1181c5b
Compare
|
/assign @derekwaynecarr @johnbelamaric |
keps/sig-node/2403-pod-resources-allocatable-resources/README.md
Outdated
Show resolved
Hide resolved
ffromani
force-pushed
the
podresources-get-alloctable-resources
branch
from
1181c5b to
2d90789
Compare
keps/sig-node/2403-pod-resources-allocatable-resources/README.md
Outdated
Show resolved
Hide resolved
keps/sig-node/2403-pod-resources-allocatable-resources/README.md
Outdated
Show resolved
Hide resolved
keps/sig-node/2403-pod-resources-allocatable-resources/README.md
Outdated
Show resolved
Hide resolved
keps/sig-node/2403-pod-resources-allocatable-resources/README.md
Outdated
Show resolved
Hide resolved
keps/sig-node/2403-pod-resources-allocatable-resources/README.md
Outdated
Show resolved
Hide resolved
keps/sig-node/2403-pod-resources-allocatable-resources/README.md
Outdated
Show resolved
Hide resolved
keps/sig-node/2403-pod-resources-allocatable-resources/README.md
Outdated
Show resolved
Hide resolved
keps/sig-node/2403-pod-resources-allocatable-resources/README.md
Outdated
Show resolved
Hide resolved
| - Metric name: `pod_resources_endpoint_requests_total` | ||
| - Components exposing the metric: kubelet | ||
|
|
||
| * **What are the reasonable SLOs (Service Level Objectives) for the above SLIs?** N/A or refer to Kubelet SLIs. |
There was a problem hiding this comment.
do we have SLIs/SLOs for the pod-resources api in general? should we expect < x% of requests to be errors?
There was a problem hiding this comment.
in general this API is expected to never fail. I'll just leave "N/A" here.
keps/sig-node/2403-pod-resources-allocatable-resources/README.md
Outdated
Show resolved
Hide resolved
|
e2e tests addition after the feature gate addition: kubernetes/kubernetes@e5c5db0 |
ffromani
force-pushed
the
podresources-get-alloctable-resources
branch
from
2d90789 to
bf341b5
Compare
keps/sig-node/2403-pod-resources-allocatable-resources/README.md
Outdated
Show resolved
Hide resolved
keps/sig-node/2403-pod-resources-allocatable-resources/README.md
Outdated
Show resolved
Hide resolved
derekwaynecarr
requested changes
Feb 5, 2021
keps/sig-node/2403-pod-resources-allocatable-resources/README.md
Outdated
Show resolved
Hide resolved
ffromani
commented
Feb 8, 2021
In order to simplify and make more understandable the KEP, and to comply with the new process, we extract the unit of work still ongoing in this KEP from kubernetes#1884 Work in this area was done during the 1.20 and 1.21 cycles in kubernetes/kubernetes#95734 Rationale, discussion and documentation for all the changes including the one proposed in this KEP have been described in https://github.com/kubernetes/enhancements/tree/master/keps/sig-node/2043-pod-resource-concrete-assigments and reported here were relevant Signed-off-by: Francesco Romani <[email protected]>
ffromani
force-pushed
the
podresources-get-alloctable-resources
branch
from
ed2dbf2 to
9e04029
Compare
k8s-ci-robot
added
the
lgtm
ffromani
added a commit
to ffromani/kubernetes
that referenced
this pull request
Mar 4, 2021
Extend the podresources API implementing the GetAllocatableResources endpoint, as specified in the KEPs: https://github.com/kubernetes/enhancements/tree/master/keps/sig-node/2043-pod-resource-concrete-assigments kubernetes/enhancements#2404 Signed-off-by: Francesco Romani <[email protected]>
ffromani
added a commit
to ffromani/kubernetes
that referenced
this pull request
Mar 5, 2021
Extend the podresources API implementing the GetAllocatableResources endpoint, as specified in the KEPs: https://github.com/kubernetes/enhancements/tree/master/keps/sig-node/2043-pod-resource-concrete-assigments kubernetes/enhancements#2404 Signed-off-by: Francesco Romani <[email protected]>
ffromani
added a commit
to ffromani/kubernetes
that referenced
this pull request
Mar 7, 2021
Extend the podresources API implementing the GetAllocatableResources endpoint, as specified in the KEPs: https://github.com/kubernetes/enhancements/tree/master/keps/sig-node/2043-pod-resource-concrete-assigments kubernetes/enhancements#2404 Signed-off-by: Francesco Romani <[email protected]>
ffromani
added a commit
to ffromani/kubernetes
that referenced
this pull request
Mar 7, 2021
Extend the podresources API implementing the GetAllocatableResources endpoint, as specified in the KEPs: https://github.com/kubernetes/enhancements/tree/master/keps/sig-node/2043-pod-resource-concrete-assigments kubernetes/enhancements#2404 Signed-off-by: Francesco Romani <[email protected]>
ffromani
added a commit
to ffromani/kubernetes
that referenced
this pull request
Mar 9, 2021
Extend the podresources API implementing the GetAllocatableResources endpoint, as specified in the KEPs: https://github.com/kubernetes/enhancements/tree/master/keps/sig-node/2043-pod-resource-concrete-assigments kubernetes/enhancements#2404 Signed-off-by: Francesco Romani <[email protected]>
6 tasks
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to simplify and make more understandable the KEP, and
to comply with the new process, we extract the unit of work still
ongoing in this KEP from #1884
Work in this area was done during the 1.20 and 1.21 cycles in
kubernetes/kubernetes#95734
Rationale, discussion and documentation for all the changes including
the one proposed in this KEP have been described in
https://github.com/kubernetes/enhancements/tree/master/keps/sig-node/2043-pod-resource-concrete-assigments
and reported here were relevant
Signed-off-by: Francesco Romani [email protected]