Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Actualize podresources 1.21 #27203

Merged
merged 3 commits into from
Mar 31, 2021
Merged

Actualize podresources 1.21 #27203

merged 3 commits into from
Mar 31, 2021

Conversation

ffromani
Copy link
Contributor

Continuation of #24641

This commit updates description according to
kubernetes/enhancements#1884
kubernetes/enhancements#2404

/milestone 1.21
Issue: kubernetes/enhancements#2403

@k8s-ci-robot
Copy link
Contributor

@fromanirh: You must be a member of the kubernetes/website-milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your Website milestone maintainers and have them propose you as an additional delegate for this responsibility.

In response to this:

Continuation of #24641

This commit updates description according to
kubernetes/enhancements#1884
kubernetes/enhancements#2404

/milestone 1.21
Issue: kubernetes/enhancements#2403

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 24, 2021
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Mar 24, 2021
@ffromani
Copy link
Contributor Author

/assign @sftim

@ffromani
Copy link
Contributor Author

@sftim FYI the only new content added from where #24641 stopped is the documentation of the new feature gate (7998bc0)

@ffromani
Copy link
Contributor Author

/sig node

@k8s-ci-robot k8s-ci-robot added the sig/node Categorizes an issue or PR as relevant to SIG Node. label Mar 24, 2021
@netlify
Copy link

netlify bot commented Mar 24, 2021

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 7998bc0

https://deploy-preview-27203--kubernetes-io-master-staging.netlify.app

@reylejano
Copy link
Member

@fromanirh If this is for the 1.21 release, please target the dev-1.21 branch

@reylejano
Copy link
Member

/assign @tengqm

@sftim
Copy link
Contributor

sftim commented Mar 24, 2021 •
edited
Loading

/hold
milestone looks wrong
target branch looks wrong

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 24, 2021
@ffromani
Copy link
Contributor Author

got it about the branch, my fault. Fixing ASAP.

@ffromani ffromani changed the base branch from master to dev-1.21 March 25, 2021 08:05
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 25, 2021
@ffromani ffromani force-pushed the actualize-podresources-1.21 branch from 7998bc0 to ee60434 Compare March 25, 2021 08:08
@k8sio-netlify-preview-bot
Copy link
Collaborator

k8sio-netlify-preview-bot commented Mar 25, 2021 •
edited
Loading

Deploy preview for kubernetes-io-vnext-staging processing.

Building with commit dace2a2

https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/6061d6d1fb635b0008caa0eb

@k8s-ci-robot k8s-ci-robot added language/es Issues or PRs related to Spanish language language/id Issues or PRs related to Indonesian language language/ko Issues or PRs related to Korean language language/pt Issues or PRs related to Portuguese language language/zh Issues or PRs related to Chinese language labels Mar 25, 2021
@ffromani ffromani force-pushed the actualize-podresources-1.21 branch from ee60434 to f468454 Compare March 25, 2021 08:10
@k8s-ci-robot k8s-ci-robot removed language/pt Issues or PRs related to Portuguese language language/zh Issues or PRs related to Chinese language labels Mar 25, 2021
@reylejano
Copy link
Member

@fromanirh can you squash the commits?
Thank you

@reylejano
Copy link
Member

@kubernetes/sig-node-pr-reviews , please provide a technical review for this PR by March 31 to get this into the release. Thank you!

@ffromani
Copy link
Contributor Author

@fromanirh can you squash the commits?
Thank you

let's hear from @AlexeyPerevalov

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 26, 2021
@ffromani ffromani force-pushed the actualize-podresources-1.21 branch from f468454 to e9b6001 Compare March 26, 2021 07:33
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 26, 2021
@AlexeyPerevalov
Copy link
Contributor

@fromanirh can you squash the commits?
Thank you

let's hear from @AlexeyPerevalov

Content looks good for me and I agree to squash all commits into one.

@ffromani
Copy link
Contributor Author

@fromanirh can you squash the commits?
Thank you

let's hear from @AlexeyPerevalov

Content looks good for me and I agree to squash all commits into one.

Thanks! to preserve different authorship, I'll squash yours into one and keep mine separated.

@AlexeyPerevalov @sftim @ffromani
Actuallize podresources description
f8d06cf 
This commit updates description according to
kubernetes/enhancements#1884

Update content/en/docs/concepts/extend-kubernetes/compute-storage-net/device-plugins.md

Signed-off-by: Alexey Perevalov <[email protected]>
Co-authored-by: Tim Bannister <[email protected]>
@ffromani ffromani force-pushed the actualize-podresources-1.21 branch from e9b6001 to 64ef876 Compare March 26, 2021 18:39
@reylejano
Copy link
Member

@fromanirh, please review sftim's comment about not linking to a kep on the features-gate page instead write a short summary for Allocatable Resources Reporting on a concepts or tasks page and link to that page on the feature-gates page

The managing resources for containers concepts page may be a good one to include a short summary on Allocatable Resources Reporting but I defer to you on which concepts or tasks page to update

sftim
sftim reviewed Mar 28, 2021
View reviewed changes
content/en/docs/concepts/extend-kubernetes/compute-storage-net/device-plugins.md Outdated
It provides more information than kubelet exports to APIServer.

```gRPC
// AvailableResourcesResponses contains information about all the devices known by the kubelet
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AvailableResourcesResponses or AllocatableResourcesResponse? Which is correct for the comment?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's AllocatableResourcesResponse. I'll clarify in a separate commit (because of different authors).

ffromani added 2 commits March 29, 2021 15:31
@ffromani
podresources: document the new feature gate
d8a2177 
Signed-off-by: Francesco Romani <[email protected]>
@ffromani
device plugins: add clarifications after review
dace2a2 
- fix the AllocatableResourcesResponse comment
- describe the NUMA ID and explain the meaning of the field.

Signed-off-by: Francesco Romani <[email protected]>
@ffromani ffromani force-pushed the actualize-podresources-1.21 branch from 64ef876 to dace2a2 Compare March 29, 2021 13:32
@irvifa
Copy link
Member

irvifa commented Mar 30, 2021

Since the branch already updated
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 30, 2021
@reylejano
Copy link
Member

/label tide/merge-method-squash
/approve

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Mar 31, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: reylejano

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 31, 2021
@reylejano
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 31, 2021
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 07842b56dc2faf6234211a9a2d64f7356aca70d7

@k8s-ci-robot k8s-ci-robot merged commit b4f485a into kubernetes:dev-1.21 Mar 31, 2021
@ffromani ffromani deleted the actualize-podresources-1.21 branch March 31, 2021 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sftim sftim sftim left review comments

@bradtopol bradtopol Awaiting requested review from bradtopol

@onlydole onlydole Awaiting requested review from onlydole

Assignees

@tengqm tengqm

@sftim sftim

@reylejano reylejano

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/node Categorizes an issue or PR as relevant to SIG Node. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
1.21
Development

Successfully merging this pull request may close these issues.
9 participants
@ffromani @k8s-ci-robot @reylejano @sftim @k8sio-netlify-preview-bot @PI-Victor @AlexeyPerevalov @irvifa @tengqm