Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

keps/sig-cluster-lifecycle/kubeadm: mark the kustomization KEP as replaced #1991

Merged
merged 1 commit into from
Sep 24, 2020
Merged

keps/sig-cluster-lifecycle/kubeadm: mark the kustomization KEP as replaced #1991

merged 1 commit into from
Sep 24, 2020

Conversation

neolit123
Copy link
Member

The feature to use kustomize in kubeadm was replaced by KEP #1739
to use raw patches.

the diff contains automatic whitespace cleanup.

@neolit123
keps/sig-cluster-lifecycle/kubeadm: "replace" the kustomization KEP
4c1c3c8 
The feature to use kustomize in kubeadm was replaced by KEP 1739
to use raw patches.
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 17, 2020
@k8s-ci-robot k8s-ci-robot added sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 17, 2020
@neolit123
Copy link
Member Author

/assign @fabriziopandini
/sig cluster-lifecycle
/kind deprecation

@k8s-ci-robot k8s-ci-robot added the kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. label Sep 17, 2020
neolit123
neolit123 commented Sep 17, 2020
View reviewed changes
keps/sig-cluster-lifecycle/kubeadm/20190722-Advanced-configurations-with-kubeadm-(Kustomize).md
last-updated: 2019-09-02
status: implementable
last-updated: 2020-09-18
status: replaced
Copy link
Member Author

@neolit123 neolit123 Sep 17, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a relevant change, the rest is whitespace cleanup.
"replaced" is an official KEP status

[1]

neolit123
neolit123 commented Sep 17, 2020
View reviewed changes
keps/sig-cluster-lifecycle/kubeadm/20190722-Advanced-configurations-with-kubeadm-(Kustomize).md
@@ -64,7 +64,10 @@ status: implementable

## Summary

This KEP is aimed at defining a new kubeadm feature that will allow users to bootstrap
**Note:** this KEP was replaced by the KEP tracked in [#1739](https://github.com/kubernetes/enhancements/issues/1739)
which uses raw patches for customization.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[1]

This was referenced Sep 18, 2020
Merged
Closed
fabriziopandini
fabriziopandini reviewed Sep 18, 2020
View reviewed changes
Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini, neolit123

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fabriziopandini
Copy link
Member

/lgmt
/hold
for letting some other people to review

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 18, 2020
@neolit123
Copy link
Member Author

@fabriziopandini please apply LGTM again, when you think it's appropriate.
we haven't gotten any objections to the change overall.

@fabriziopandini
Copy link
Member

/lgtm
/hold cancel

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Sep 24, 2020
@k8s-ci-robot k8s-ci-robot merged commit 6200154 into kubernetes:master Sep 24, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Sep 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabriziopandini fabriziopandini fabriziopandini left review comments

@justinsb justinsb Awaiting requested review from justinsb

@timothysc timothysc Awaiting requested review from timothysc

Assignees

@fabriziopandini fabriziopandini

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.20
Development

Successfully merging this pull request may close these issues.
3 participants
@neolit123 @k8s-ci-robot @fabriziopandini