Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kubeadm: customization with patches #1739

Open
neolit123 opened this issue May 4, 2020 · 32 comments
Open

kubeadm: customization with patches #1739

neolit123 opened this issue May 4, 2020 · 32 comments
Assignees
@neolit123
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. stage/beta Denotes an issue tracking an enhancement targeted for Beta status

Comments

@neolit123
Copy link
Member

neolit123 commented May 4, 2020 •
edited
Loading

Enhancement Description

Please to keep this description up to date. This will help the Enhancement Team track efficiently the evolution of the enhancement

kubeadm tracking issue:
kubernetes/kubeadm#2046

this feature replaces and existing feature added with this KEP:
https://github.com/kubernetes/enhancements/blob/master/keps/sig-cluster-lifecycle/kubeadm/20190722-Advanced-configurations-with-kubeadm-(Kustomize).md
@neolit123 neolit123 added the sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. label May 4, 2020
@neolit123 neolit123 self-assigned this May 4, 2020
@neolit123 neolit123 added the kind/feature Categorizes issue or PR as related to a new feature. label May 4, 2020
@neolit123 neolit123 mentioned this issue May 4, 2020
Merged
@palnabarun
Copy link
Member

Hey @neolit123 -- 1.19 Enhancements Lead here. I wanted to check in and see if you think this Enhancement will be graduating to Alpha in 1.19?

In order to have this part of the release:

  1. The KEP PR must be merged in an implementable state
  2. The KEP must have test plans
  3. The KEP must have graduation criteria.

The current release schedule is:

  • Monday, April 13: Week 1 - Release cycle begins
  • Tuesday, May 19: Week 6 - Enhancements Freeze
  • Thursday, June 25: Week 11 - Code Freeze
  • Thursday, July 9: Week 14 - Docs must be completed and reviewed
  • Tuesday, August 4: Week 17 - Kubernetes v1.19.0 released

@neolit123
Copy link
Member Author

hi, yes the feature is planned as alpha for 1.19.
the KEP in #1742 should merge as "implementable" before the 19th.

@palnabarun
Copy link
Member

@neolit123 Awesome! 🎆 Thank you for the update.

I am going ahead and updating the tracking sheet accordingly.

PS: Until the PR gets merged, I'm marking the enhancement At Risk. Once, the PR gets merged, I would update the status.

@palnabarun
Copy link
Member

/stage alpha
/milestone v1.19

@k8s-ci-robot k8s-ci-robot added the stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status label May 11, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone May 11, 2020
@palnabarun palnabarun added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label May 11, 2020
@neolit123
Copy link
Member Author

@palnabarun

PS: Until the PR gets merged, I'm marking the enhancement At Risk. Once, the PR gets merged, I would update the status.

hi, the KEP merged as "implementable":
#1742
https://github.com/kubernetes/enhancements/pull/1742/files#diff-43d8c9f7a843e756c4e752fd1f7fbe44R8

@neolit123 neolit123 mentioned this issue May 18, 2020
Closed
14 tasks
@palnabarun
Copy link
Member

@neolit123 -- Thanks for the ping. I have updated the tracking sheet. 👍

@palnabarun
Copy link
Member

PS: I have updated the issue description with the link to the KEP.

@msedzins
Copy link

Hi @neolit123 , enhancement shadow here -- Can you please link to all the implementation PR's here - k/k or otherwise? 🙂

The current release schedule is:

  • Monday, April 13: Week 1 - Release cycle begins
  • Tuesday, May 19: Week 6 - Enhancements Freeze
  • Thursday, June 25: Week 11 - Code Freeze
  • Thursday, July 9: Week 14 - Docs must be completed and reviewed
  • Tuesday, August 4: Week 17 - Kubernetes v1.19.0 released

@neolit123
Copy link
Member Author

@msedzins hi, the PRs are not created yet, but i can link them once that is done.

@msedzins
Copy link

Thank you @neolit123!

@divya-mohan0209
Copy link
Contributor

Hello @neolit123 , I'm one of the v1.19 docs shadows.

Could you please let me know if this piece of enhancement work planned for 1.19 release requires any new docs (or modifications to existing docs)?

If not, can you please update the 1.19 Enhancement Tracker Sheet (or let me know and I'll do so)

If yes, just a friendly reminder we're looking for a PR against k/website (branch dev-1.19) due by Friday, June 12, it can just be a placeholder PR at this time.

Please do let me know if you have any questions!

Regards,
Divya

@neolit123
Copy link
Member Author

hi, @divya-mohan0209 this feature will only be documented in the help message for a command line flag in its Alpha state, but we do plan to have e2e tests for the Alpha.

@divya-mohan0209
Copy link
Contributor

So to clarify my understanding @neolit123 , you will not be requiring documentation on the Kubernetes website right?

@neolit123
Copy link
Member Author

correct. for 1.19 we don't need k/website PRs.

@divya-mohan0209
Copy link
Contributor

Alright, thank you for the confirmation!

@msedzins
Copy link

msedzins commented Jun 3, 2020

Hi @neolit123, any update on PRs?

Thank you.

@neolit123
Copy link
Member Author

not yet.

@neolit123
Copy link
Member Author

WIP PR is here (more commits to be added this week): kubernetes/kubernetes#92017

@msedzins
Copy link

Thank you @neolit123!

@msedzins
Copy link

Hi, @neolit123

This is a follow-up to the communication that went out to k-dev today. There has been a revision to the release schedule of v1.19 as follows.

Thursday, July 9th: Week 13 - Code Freeze
Thursday, July 16th: Week 14 - Docs must be completed and reviewed
Tuesday, August 25th: Week 20 - Kubernetes v1.19.0 released
Thursday, August 27th: Week 20 - Release Retrospective

You can find the revised Schedule in the sig-release Repo

Please let me know if you have any questions. 🖖

@msedzins
Copy link

msedzins commented Jul 8, 2020

Hi @neolit123 , from what I can see this enhancement is Code complete so it's ready for Code freeze deadline which happens July 9th.
Please let me know if you think otherwise and there are any risks for that enhancement to be included in v.1.19.

@neolit123
Copy link
Member Author

neolit123 commented Jul 8, 2020 •
edited
Loading

@msedzins hi, the code changes merged:
kubernetes/kubernetes#92017

e2e PRs too:
kubernetes/test-infra#17934
kubernetes/kubeadm#2184

docs are planned for the beta.

@kikisdeliveryservice kikisdeliveryservice removed this from the v1.19 milestone Sep 11, 2020
@kikisdeliveryservice
Copy link
Member

Hi @neolit123

Enhancements Lead here. Any plans for this in 1.20?

Thanks!
Kirsten

@neolit123
Copy link
Member Author

neolit123 commented Sep 14, 2020 via email

@kikisdeliveryservice kikisdeliveryservice added the tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team label Sep 14, 2020
@neolit123 neolit123 mentioned this issue Sep 17, 2020
Merged
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 13, 2020
@neolit123
Copy link
Member Author

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 14, 2020
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 14, 2021
@neolit123
Copy link
Member Author

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 15, 2021
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 13, 2021
@neolit123
Copy link
Member Author

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 5, 2021
@neolit123 neolit123 added stage/beta Denotes an issue tracking an enhancement targeted for Beta status and removed stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status labels Sep 9, 2021
@neolit123 neolit123 mentioned this issue Sep 9, 2021
Merged
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 8, 2021
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jan 7, 2022
@neolit123 neolit123 added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. labels Jan 10, 2022
This was referenced May 11, 2022
Closed
Merged
@Atharva-Shinde Atharva-Shinde removed the tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team label May 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@neolit123 neolit123

Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. stage/beta Denotes an issue tracking an enhancement targeted for Beta status
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
9 participants
@neolit123 @kikisdeliveryservice @msedzins @palnabarun @k8s-ci-robot @divya-mohan0209 @fejta-bot @k8s-triage-robot @Atharva-Shinde