Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kubeadm: remove the --experimental-kustomize feature #94871

Merged
merged 2 commits into from
Sep 24, 2020
Merged

kubeadm: remove the --experimental-kustomize feature #94871

merged 2 commits into from
Sep 24, 2020

Conversation

neolit123
Copy link
Member

@neolit123 neolit123 commented Sep 18, 2020 •
edited
Loading

What this PR does / why we need it:

The feature was replaced by --experimental-patches and deprecated in
1.19.

Second commit updates go.mod and vendor/modules.txt.

Which issue(s) this PR fixes:

xref kubernetes/kubeadm#2046
xref kubernetes/enhancements#1991

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

action-required: kubeadm: remove the deprecated feature --experimental-kustomize from kubeadm commands. The feature was replaced with --experimental-patches in 1.19. To migrate see the --help description for the --experimental-patches flag.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP]: https://github.com/kubernetes/enhancements/tree/master/keps/sig-cluster-lifecycle/kubeadm/1739-customization-with-patches

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Sep 18, 2020
@neolit123
Copy link
Member Author

/kind deprecation
/priority important-soon

@k8s-ci-robot k8s-ci-robot added kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Sep 18, 2020
@neolit123 neolit123 mentioned this pull request Sep 18, 2020
Closed
14 tasks
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 18, 2020
@k8s-ci-robot k8s-ci-robot added area/kubeadm sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. area/dependency Issues or PRs related to dependency changes and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 18, 2020
@neolit123 neolit123 force-pushed the 1.20-kubeadm-remove-experimental-kustomize branch from 687e645 to 3d9b7df Compare September 18, 2020 00:43
@neolit123 neolit123 force-pushed the 1.20-kubeadm-remove-experimental-kustomize branch from 3d9b7df to a87eb55 Compare September 18, 2020 00:50
@neolit123
Copy link
Member Author

the removal was announced on the SIG CL mailing list as well:
https://groups.google.com/g/kubernetes-sig-cluster-lifecycle/c/bv8ZbpmO5Q8

fabriziopandini
fabriziopandini reviewed Sep 18, 2020
View reviewed changes
Copy link
Member

@fabriziopandini fabriziopandini left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@neolit123 thanks for this PR!
Changes seem pretty straight forward to me. Ready to approve as soon a WIP is removed

@neolit123
Copy link
Member Author

/milestone v1.20
removing WIP

@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Sep 23, 2020
@neolit123 neolit123 changed the title WIP: kubeadm: remove the --experimental-kustomize feature kubeadm: remove the --experimental-kustomize feature Sep 23, 2020
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 23, 2020
@fabriziopandini
Copy link
Member

/lgtm
/hold
@yagonobre do you mind taking a look at this PR?

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 24, 2020
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 24, 2020
@yagonobre
Copy link
Member

I'll take a look in a bit

yagonobre
yagonobre reviewed Sep 24, 2020
View reviewed changes
Copy link
Member

@yagonobre yagonobre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to remove the hold as soon as you want.
/lgtm

vendor/modules.txt Show resolved Hide resolved
@neolit123
Copy link
Member Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 24, 2020
@neolit123
Copy link
Member Author

/assign @liggitt
PTAL for approval on the go.mod/vendor changes.

@liggitt
Copy link
Member

liggitt commented Sep 24, 2020

/approve
for go.mod / vendor changes

/hold for approve from kubeadm reviewers

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 24, 2020
@liggitt
Copy link
Member

liggitt commented Sep 24, 2020

oops, missed #94871 (review) already lgtmed.

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 24, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, neolit123

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 24, 2020
@neolit123
Copy link
Member Author

thanks

@k8s-ci-robot k8s-ci-robot merged commit 770eb2c into kubernetes:master Sep 24, 2020
This was referenced Sep 24, 2020
Merged
Merged
@github-actions github-actions bot mentioned this pull request Sep 29, 2020
Open
@fabriziopandini fabriziopandini mentioned this pull request Oct 7, 2020
Closed
@dhiller dhiller mentioned this pull request Dec 11, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yagonobre yagonobre yagonobre left review comments

@fabriziopandini fabriziopandini fabriziopandini left review comments

@liggitt liggitt liggitt left review comments

@ereslibre ereslibre Awaiting requested review from ereslibre

Assignees

@liggitt liggitt

@fabriziopandini fabriziopandini

@yagonobre yagonobre

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dependency Issues or PRs related to dependency changes area/kubeadm cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
v1.20
Development

Successfully merging this pull request may close these issues.
5 participants
@neolit123 @fabriziopandini @yagonobre @liggitt @k8s-ci-robot