Cloud Dual-Stack --node-ip Handling

[danwinship]

Enhancement Description

• One-line enhancement description (can be used as a release note): Synchronize --node-ip behavior between cloud-provider and non-cloud-provider clusters, to improve dual-stack behavior in clouds.
• Kubernetes Enhancement Proposal: https://github.com/kubernetes/enhancements/tree/master/keps/sig-network/3705-cloud-node-ips
• Discussion Link: For dual stack deployments, node addresses show only one IP if node-ip parameter is passed kubernetes#111695 (comment) (and following comments), KEP-1664: Better Support for Dual-Stack Node Addresses #1665
• Primary contact (assignee): @danwinship
• Responsible SIGs: sig-network, with help from sig-node and sig-cloud-provider
• Enhancement target (which target equals to which milestone):
  • Alpha release target (x.y): 1.27
  • Beta release target (x.y): 1.29
  • Stable release target (x.y): 1.30
• Alpha
  • KEP (k/enhancements) update PR(s):
    • KEP-3705: Cloud Dual-Stack --node-ip Handling #3706
    • KEP-3705: update CloudNodeIPs to implementable #3798
    • add new template question to KEP-3453 and KEP-3705 #3849
  • Code (k/k) update PR(s):
    • KEP-3705 cloud dual-stack --node-ip kubernetes#116305
  • Docs (k/website) update PR(s):
    • Add docs for CloudDualStackNodeIPs docs (KEP-3705) website#40188
• Beta
  • KEP (k/enhancements) update PR(s):
    • KEP-3705: simplify initial alpha, discuss possible changes to plan #3898
    • KEP-3705: update CloudDualStackNodeIPs to beta #3975
    • KEP-3705: fix beta/GA releases for CloudDualStackNodeIPs #4170
  • Code (k/k) update PR(s):
    • Set the node-ips annotation correctly with CloudDualStackNodeIPs kubernetes#118329
    • Bump CloudDualStackNodeIPs to beta for 1.29 kubernetes#120275
  • Docs (k/website) update(s):
    • update CloudDualStackNodeIPs to beta website#42875
• Stable
  • KEP (k/enhancements) update PR(s): KEP-3705: CloudDualStackNodeIPs to GA #4415
  • Code (k/k) update PR(s): KEP-3705 CloudDualStackNodeIPs to GA kubernetes#123134
  • Docs (k/website) update(s): KEP-3705 CloudDualStackNodeIPs to GA website#45028

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

[danwinship]

/sig network
/sig node
/sig cloud-provider

[wojtek-t]

/label lead-opted-in

@thockin - FYI ^^

[Atharva-Shinde]

Hello @danwinship @thockin 👋, Enhancements team here.

Just checking in as we approach Enhancements freeze on 18:00 PDT Thursday 9th February 2023.

This enhancement is targeting for stage alpha for 1.27 (correct me, if otherwise)

Here's where this enhancement currently stands:

• KEP readme using the latest template has been merged into the k/enhancements repo.
• KEP status is marked as implementable for latest-milestone: 1.27
• KEP readme has a updated detailed test plan section filled out
• KEP readme has up to date graduation criteria
• KEP has a production readiness review that has been completed and merged into k/enhancements.

For this KEP, we would just need to update the following:

• Add response for this question in the Scalability questionnaire of the KEP readme
• Referring to this discussion, we need to add a reviewer.

The status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

[Atharva-Shinde]

/stage alpha

[Atharva-Shinde]

Thanks @danwinship, with all the KEP requirements in place and merged into k/enhancements, this enhancement is all good for the upcoming enhancements freeze. 🚀

The status of this enhancement is marked as tracked. Please keep the issue description up-to-date with appropriate stages as well :)

[Rishit-dagli]

Hi @danwinship 👋, I’m reaching out from the 1.27 Release Docs team. This enhancement is marked as ‘Needs Docs’ for the 1.27 release.

Please follow the steps detailed in the documentation to open a PR against dev-1.27 branch in the k/website repo. This PR can be just a placeholder at this time, and must be created by March 16. For more information, please take a look at Documenting for a release to familiarize yourself with the documentation requirements for the release.
Please feel free to reach out with any questions. Thanks!

[Atharva-Shinde]

Hey again @danwinship 👋 Enhancements team here,
Just checking in as we approach 1.27 code freeze at 17:00 PDT on Tuesday 14th March 2023.

Here's where this enhancement currently stands:

• All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
• All PR/s are fully merged by the code freeze deadline.
  • Move GetHostname() from k/k/pkg/util/node to k/component-helpers/node/util kubernetes#115338
  • Delete the cloud node IP annotation if it is stale kubernetes#112184
  • KEP-3705 cloud dual-stack --node-ip kubernetes#116305

Also please let me know if there are other PRs in k/k we should be tracking for this KEP.
As always, we are here to help if any questions come up. Thanks!

[pnbrown]

Hey again @danwinship 👋 Enhancements team here,

Just checking in as we approach code freeze at 02:00 UTC Wednesday 6th March 2024 .

Here's where this enhancement currently stands:

• All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
• All PR/s are ready to be merged (they have approved and lgtm labels applied) by the code freeze deadline. This includes tests.

Also, please let me know if there are other PRs in k/k we should be tracking for this KEP.
As always, we are here to help if any questions come up. Thanks!

[thockin]

GA'd in 30, cleanup in 32

[sreeram-venkitesh]

Hi! v1.31 Enhancements lead here 👋🏼

I'm assuming the status will be updated to implemented in v1.32 along with the cleanup, right? I'll remove the lead-opted-in label and remove this KEP from the v1.31 tracking board. Please let me know if this works.

/remove-label lead-opted-in

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue as fresh with /remove-lifecycle stale
• Close this issue with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[k8s-triage-robot]

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue as fresh with /remove-lifecycle rotten
• Close this issue with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

[SergeyKanzhelev]

/remove-lifecycle rotten

[SergeyKanzhelev]

This seems to be cleaned up: kubernetes/kubernetes#126840

[thockin]

Is this complete now? Time to close the issue?

[SergeyKanzhelev]

Yes, it seems so.

Status is implemented:

enhancements/keps/sig-network/3705-cloud-node-ips/kep.yaml

Line 9 in 9679329

status: implemented

And things are cleaned up from the k/k.

/close

[k8s-ci-robot]

@SergeyKanzhelev: Closing this issue.

In response to this:

Yes, it seems so.

Status is implemented:

enhancements/keps/sig-network/3705-cloud-node-ips/kep.yaml

Line 9 in 9679329

status: implemented

And things are cleaned up from the k/k.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.