Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KEP-3705: fix beta/GA releases for CloudDualStackNodeIPs #4170

Merged
merged 1 commit into from
Sep 1, 2023

Conversation

danwinship
Copy link
Contributor

  • One-line PR description: fix release versions for KEP-3705, which didn't actually go beta in 1.28

/assign @thockin

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 1, 2023
@k8s-ci-robot k8s-ci-robot requested review from dcbw and thockin September 1, 2023 13:39
@k8s-ci-robot k8s-ci-robot added kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/network Categorizes an issue or PR as relevant to SIG Network. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 1, 2023
Copy link
Member

@thockin thockin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 1, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danwinship, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 1, 2023
@k8s-ci-robot k8s-ci-robot merged commit 7a5323a into kubernetes:master Sep 1, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.29 milestone Sep 1, 2023
@danwinship danwinship deleted the kep-3705-beta-update branch September 1, 2023 17:47
@lubronzhan
Copy link

lubronzhan commented Oct 4, 2023

Hi @danwinship , in k8s 1.28, does it support syntax like --node-ip ::,0.0.0.0.
In the KEP it only mentioned either pass :: or 0.0.0.0
And --node-ip ipv6,ipv4 was dropped.

Update
Ok I see the comment at the bottom, why the --node-ip ipv6,ipv4 was dropped. Then we won't support --node-ip ::,0.0.0.0 as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/network Categorizes an issue or PR as relevant to SIG Network. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants