-
Notifications
You must be signed in to change notification settings - Fork 39.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KEP-3705 CloudDualStackNodeIPs to GA #123134
Conversation
a853f45
to
4ddf69a
Compare
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
/lgtm
/approve
LGTM label has been added. Git tree hash: 28a9a5fc988e87999ceb8bb260231567be8f7da9
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danwinship, thockin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass. This bot retests PRs for certain kubernetes repos according to the following rules:
You can:
/retest |
/triage accepted |
Changelog suggestion -The CloudDualStackNodeIPs feature is now GA and the feature gate is always
-enabled, meaning that dual-stack `kubelet --node-ip` values are always supported
+Graduated dual-stack support for kubelet cloud provider integrations.
+The feature is now GA and the `CloudDualStackNodeIPs` feature gate is always
+enabled, meaning that dual-stack `kubelet --node-ip` values are always supported
(when using an external cloud provider that supports dual stack). |
That makes it sound bigger than it is... how about
? |
What this PR does / why we need it:
Moves KEP-3705 CloudDualStackNodeIPs to GA, as per kubernetes/enhancements#4415
Special notes for your reviewer:
I removed the
allowCloudDualStack
argument fromParseNodeIPArgument
(since it would always betrue
now) but left thecloudProvider
argument since kubelet still has some code for the legacy providers?Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
/kind feature
/priority important-soon
/assign @thockin