Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KEP-3705 CloudDualStackNodeIPs to GA #123134

Merged
merged 2 commits into from
Feb 6, 2024

Conversation

danwinship
Copy link
Contributor

@danwinship danwinship commented Feb 5, 2024

What this PR does / why we need it:

Moves KEP-3705 CloudDualStackNodeIPs to GA, as per kubernetes/enhancements#4415

Special notes for your reviewer:

I removed the allowCloudDualStack argument from ParseNodeIPArgument (since it would always be true now) but left the cloudProvider argument since kubelet still has some code for the legacy providers?

Does this PR introduce a user-facing change?

Graduated support for passing dual-stack `kubelet --node-ip` values when using
a cloud provider. The feature is now GA and the `CloudDualStackNodeIPs` feature
gate is always enabled.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP]: https://github.com/kubernetes/enhancements/issues/3705

/kind feature
/priority important-soon
/assign @thockin

@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Feb 5, 2024
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Feb 5, 2024
@k8s-ci-robot k8s-ci-robot added area/cloudprovider area/kubelet sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/node Categorizes an issue or PR as relevant to SIG Node. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Feb 5, 2024
@danwinship
Copy link
Contributor Author

/retest

Copy link
Member

@thockin thockin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 6, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 28a9a5fc988e87999ceb8bb260231567be8f7da9

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danwinship, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 6, 2024
@k8s-triage-robot
Copy link

The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass.

This bot retests PRs for certain kubernetes repos according to the following rules:

  • The PR does have any do-not-merge/* labels
  • The PR does not have the needs-ok-to-test label
  • The PR is mergeable (does not have a needs-rebase label)
  • The PR is approved (has cncf-cla: yes, lgtm, approved labels)
  • The PR is failing tests required for merge

You can:

/retest

@k8s-ci-robot k8s-ci-robot merged commit 920333b into kubernetes:master Feb 6, 2024
16 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.30 milestone Feb 6, 2024
@danwinship danwinship deleted the kep-3705-to-ga branch February 6, 2024 13:56
@seans3
Copy link
Contributor

seans3 commented Feb 8, 2024

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Feb 8, 2024
@sftim
Copy link
Contributor

sftim commented Feb 9, 2024

Changelog suggestion

-The CloudDualStackNodeIPs feature is now GA and the feature gate is always
-enabled, meaning that dual-stack `kubelet --node-ip` values are always supported
+Graduated dual-stack support for kubelet cloud provider integrations.
+The feature is now GA and the `CloudDualStackNodeIPs`  feature gate is always
+enabled, meaning that dual-stack `kubelet --node-ip` values are always supported
 (when using an external cloud provider that supports dual stack). 

@danwinship
Copy link
Contributor Author

+Graduated dual-stack support for kubelet cloud provider integrations.

That makes it sound bigger than it is... how about

Graduated support for passing dual-stack `kubelet --node-ip` values when using
a cloud provider. The feature is now GA and the `CloudDualStackNodeIPs`  feature
gate is always enabled.

?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cloudprovider area/kubelet cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/node Categorizes an issue or PR as relevant to SIG Node. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
Development

Successfully merging this pull request may close these issues.

6 participants