Cherry limits to 04 #2116
Merged
Cherry limits to 04 #2116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
There is some import confusion in test. Otherwise lgtm |
jbartosik
force-pushed
the
cherry-limits-to-04
branch
from
a8a16fb to
6608813
Compare
Conflicts: vertical-pod-autoscaler/pkg/admission-controller/logic/server_test.go
The test relied on order of iterating through map. Conflicts: vertical-pod-autoscaler/pkg/admission-controller/logic/server_test.go
Prepare for setting limits
- Name test cases, - Drop duplicated test case, - Simpler error handling of invalid expected resource amounts, - Format code more in line with other tests.
Conflicts: vertical-pod-autoscaler/pkg/admission-controller/logic/recommendation_provider.go
Conflicts: vertical-pod-autoscaler/pkg/admission-controller/logic/recommendation_provider.go
Users should use ContainerResourcePolicy if they want to control VPA recommendation range.
I think it's useful to revers condtions in the tests when dropping capping to limits to make sure are the relevant code is gone. I don't think it's an useful test to keep around.
Except when proportion is huge and recommendation is huge which would result in milli limit exceeding int64 maximum. Then cap the limit milli value to int63 max. Conflicts: vertical-pod-autoscaler/pkg/admission-controller/logic/recommendation_provider.go
jbartosik
force-pushed
the
cherry-limits-to-04
branch
from
6608813 to
a1a634e
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bskiba The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pick:
PRs preparing VPA for limit and limit range support:
#1879
#1880
#1950
#1990
PRs implementing support for limits:
#1993
#1997
#1998
#2005
This is analogous to #2105 but this one had conflicts (mostly import changes, one in unit tests)