Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If user set limit to the same value as request keep them in sync #1993

Merged
merged 1 commit into from
May 7, 2019
Merged

If user set limit to the same value as request keep them in sync #1993

merged 1 commit into from
May 7, 2019

Conversation

jbartosik
Copy link
Collaborator

No description provided.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 7, 2019
@jbartosik
Copy link
Collaborator Author

/assign @bskiba
/assign @kgolab

@k8s-ci-robot
Copy link
Contributor

@jbartosik: GitHub didn't allow me to assign the following users: kgolab.

Note that only kubernetes members and repo collaborators can be assigned and that issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @bskiba
/assign @kgolab

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 7, 2019
@k8s-ci-robot k8s-ci-robot requested review from bskiba and mwielgus May 7, 2019 09:25
@jbartosik jbartosik force-pushed the set-resource-limits branch 2 times, most recently from 732679d to c87f0da Compare May 7, 2019 09:32
@jbartosik jbartosik force-pushed the set-resource-limits branch from c87f0da to 6a4e755 Compare May 7, 2019 10:44
bskiba
bskiba reviewed May 7, 2019
View reviewed changes
Copy link
Member

@bskiba bskiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
One small comment

vertical-pod-autoscaler/pkg/admission-controller/logic/server.go Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 7, 2019
@jbartosik jbartosik force-pushed the set-resource-limits branch from 6a4e755 to 21d73b0 Compare May 7, 2019 12:16
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 7, 2019
@bskiba
Copy link
Member

bskiba commented May 7, 2019

Thanks!
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 7, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bskiba

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 7, 2019
@k8s-ci-robot k8s-ci-robot merged commit a98f825 into kubernetes:master May 7, 2019
@jbartosik jbartosik deleted the set-resource-limits branch May 7, 2019 12:33
This was referenced Jun 7, 2019
Merged
Merged
@danielmellado danielmellado mentioned this pull request Oct 24, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bskiba bskiba bskiba left review comments

@mwielgus mwielgus Awaiting requested review from mwielgus

Assignees

@bskiba bskiba

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jbartosik @k8s-ci-robot @bskiba