Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry limit 05 #2105

Merged
merged 12 commits into from
Jun 7, 2019
Merged

Cherry limit 05 #2105

merged 12 commits into from
Jun 7, 2019

Conversation

jbartosik
Copy link
Collaborator

@jbartosik jbartosik commented Jun 7, 2019 •
edited
Loading

jbartosik added 5 commits June 7, 2019 13:29
@jbartosik
Basic unit tests for VPA server
0006a07
@jbartosik
Fix comparing errors, make flaky test case a separate test
64436ae 
The test relied on order of iterating through map.
@jbartosik
Add test for VPA validation in Admission Controller
7b78116
@jbartosik
Break getPatchesForPodResourceRequest into smaller functions
e6b848c 
Prepare for setting limits
@jbartosik
Clean up VPA recommendation provider unit tests
3c40d61 
- Name test cases,
- Drop duplicated test case,
- Simpler error handling of invalid expected resource amounts,
- Format code more in line with other tests.
@jbartosik
Copy link
Collaborator Author

/assign @bskiba

@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 7, 2019
@k8s-ci-robot k8s-ci-robot requested review from bskiba and mwielgus June 7, 2019 11:34
@jbartosik
Copy link
Collaborator Author

/hold

Actually I think it will be cleaner if cherry pick all commits in a single PR

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 7, 2019
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jun 7, 2019
jbartosik added 5 commits June 7, 2019 13:38
@jbartosik
Add e2e test for keeping limit equal to request
62fd787
@jbartosik
Stop capping recommendations to limit
77ea843 
Users should use ContainerResourcePolicy if they want to control VPA
recommendation range.
@jbartosik
Preserve proportion between limit and request
b73499a 
Except when proportion is huge and recommendation is huge which would
result in milli limit exceeding int64 maximum. Then cap the limit milli
value to int63 max.
@jbartosik
Replace test for capping recomendation
877002b
@jbartosik
Drop an uninteresting test
14a589b 
I think it's useful to revers condtions in the tests when dropping
capping to limits to make sure are the relevant code is gone. I don't
think it's an useful test to keep around.
@jbartosik
Copy link
Collaborator Author

Next PR to cherry pick (#2049) has some merge conflicts so I think it's best to have PRs that I was able to cherry pick automatically in a separate PR. Please review.

/hold cancel
/assign @bskiba

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 7, 2019
bskiba
bskiba approved these changes Jun 7, 2019
View reviewed changes
Copy link
Member

@bskiba bskiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 7, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bskiba

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 7, 2019
@k8s-ci-robot k8s-ci-robot merged commit 509f404 into kubernetes:vpa-release-0.5 Jun 7, 2019
@jbartosik jbartosik mentioned this pull request Jun 7, 2019
Merged
@jbartosik jbartosik deleted the cherry-limit-05 branch June 10, 2019 06:23
This was referenced Jun 11, 2019
Merged
Merged
@amshuman-kr amshuman-kr mentioned this pull request Aug 16, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bskiba bskiba bskiba approved these changes

@mwielgus mwielgus Awaiting requested review from mwielgus

Assignees

@bskiba bskiba

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jbartosik @k8s-ci-robot @bskiba