CA: AWS Pricing API inaccurate for generating instance type templates

[gjtempleton]

Ran into this as part of #2550, follow up to #2240

It seems that the pricing API which we are currently using for generating our instance type list in https://github.com/kubernetes/autoscaler/blob/master/cluster-autoscaler/cloudprovider/aws/aws_util.go#L55 doesn't always return trustworthy data.

This can be seen in the fact that when running the make generate step this morning the c3.8xlarge template suddenly claims that c3.8xlarge instances possess 36 vCPUs in all regions. Using a boto3 client with ec2_client.describe_instance_types(InstanceTypes=["c3.8xlarge"]), checking against the AWS console and launching an instance (into eu-west-1 all return that they still have 32 vCPUs.

We have also had to correct previously incorrect values which are now correctly returned (see #2550 for the discussion of one correction on the memory of c5d.12xlarge instances.)

In addition the pricing API seems to return differing instance type values for some instance families than those used by the SDKs, e.g. the u- family have their .metal designations dropped by the pricing API.

e.g. from running curl https://pricing.us-east-1.amazonaws.com/offers/v1.0/aws/AmazonEC2/current/eu-west-1/index.json | jq this morning:

I'm working on a proof of concept replacing the current pricing API implementation with one using SDK calls instead at the moment, should be done by the end of the week.

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[fejta-bot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

[fejta-bot]

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

[k8s-ci-robot]

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.