Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS CN Pricing endpoint #3276

Closed
duweihello opened this issue Jul 3, 2020 · 12 comments
Closed

AWS CN Pricing endpoint #3276

duweihello opened this issue Jul 3, 2020 · 12 comments
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@duweihello
Copy link

ec2PricingServiceUrlTemplate = "https://pricing.us-east-1.amazonaws.com/offers/v1.0/aws/AmazonEC2/current/%s/index.json"

the pricing API is not support AWS CN regions, is there any alternative way to pass it?

@BellonXiao
Copy link

BellonXiao commented Jul 14, 2020

Same issue here with 1.17.2:
aws_util.go:86] Error unmarshalling https://pricing.us-east-1.amazonaws.com/offers/v1.0/aws/AmazonEC2/current/cn-north-1/index.json, skip..
aws_cloud_provider.go:363] Failed to generate AWS EC2 Instance Types: unable to load EC2 Instance Type list

endpoint for AWS CN (both regions) should be https://pricing.cn-north-1.amazonaws.com.cn/offers/v1.0/cn/AmazonEC2/current/index.json

@gjtempleton
Copy link
Member

I think the ideal way to resolve this is to move away from the use of the pricing API. Alternatively you should now (as of the latest releases) be able to use the hardcoded list by using the aws-use-static-instance-list flag set to true as it'll no longer attempt to call the pricing API.

I'd meant to move away from the pricing APIs to resolve #2696 which includes some of the other issues with the use of the Pricing API and never got around to it earlier in the year. I'll see if I can find the time to pick this work back up.

@greenu
Copy link

greenu commented Aug 19, 2020

related issue #3076

@momkeller
Copy link

I am also running into this issue in cn-north-1 using AS 1.15.7. Is there a workaround or projected fix date?

qqshfox added a commit to qqshfox/autoscaler that referenced this issue Sep 18, 2020
qqshfox added a commit to qqshfox/autoscaler that referenced this issue Sep 18, 2020
@marcheil
Copy link

marcheil commented Sep 22, 2020

Using 1.17.2,So what is the work around here for clusters that do not have internet access? How do we set the aws-use-static-instance-list flag?

@Jeffwan
Copy link
Contributor

Jeffwan commented Sep 23, 2020

I approve PR #3528.
Let's wait for the next release

yiuc added a commit to yiuc/quickstart-amazon-eks that referenced this issue Oct 20, 2020
[issue](kubernetes/autoscaler#3276)
[tempory fix](kubernetes/autoscaler#3076) is set aws-use-static-instance-list = true
@jumping
Copy link

jumping commented Nov 4, 2020

Is there any scheduler to merge the fix into some release ?

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 2, 2021
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Mar 4, 2021
@fejta-bot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-contributor-experience at kubernetes/community.
/close

@k8s-ci-robot
Copy link
Contributor

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-contributor-experience at kubernetes/community.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@zweizhang
Copy link

zweizhang commented May 19, 2021

I got the same issue with the CA version is 9.9.2.
And follow gjtempleton advice, I add the aws-use-static-instance-list to vaule file, and fix the CN Pricing issue.
Hoping it can help others.

cluster-autoscaler$ ls
Chart.yaml  README.md  README.md.gotmpl  templates  values.yaml
cluster-autoscaler$ cat values.yaml

extraArgs:
  logtostderr: true
  stderrthreshold: info
  v: 4
  # write-status-configmap: true
  # status-config-map-name: cluster-autoscaler-status
  # leader-elect: true
  # skip-nodes-with-local-storage: true
  # expander: random
  # scale-down-enabled: true
  # balance-similar-node-groups: true
  # min-replica-count: 0
  # scale-down-utilization-threshold: 0.5
  # scale-down-non-empty-candidates-count: 30
  # max-node-provision-time: 15m0s
  # scan-interval: 10s
  # scale-down-delay-after-add: 10m
  # scale-down-delay-after-delete: 0s
  # scale-down-delay-after-failure: 3m
  # scale-down-unneeded-time: 10m
  # skip-nodes-with-system-pods: true
  aws-use-static-instance-list: true    ------------>Add this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Development

No branches or pull requests