Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Load EC2 instance list dynamically when cluster autoscaler starts up #2240

Closed
Jeffwan opened this issue Aug 5, 2019 · 3 comments
Closed

Load EC2 instance list dynamically when cluster autoscaler starts up #2240

Jeffwan opened this issue Aug 5, 2019 · 3 comments
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@Jeffwan
Copy link
Contributor

Jeffwan commented Aug 5, 2019

/feature /improvement

Right now, aws instance templates ec2_instance_types.go are generate by ec2_instance_types/gen.go. Everytime Ec2 rollout new instances, this file needs to be regenerated and CA needs to roll out new images.

This can be improved by generating ec2 instance types in runtime. Either at the time CA starts or the first time to get the instance list. With this, we don't need to frequently update this file and cherry-pick to elder versions.
This was referenced Aug 5, 2019
Merged
Merged
@Jeffwan
Copy link
Contributor Author

Jeffwan commented Aug 13, 2019 •
edited
Loading

/assign

@seh seh mentioned this issue Sep 24, 2019
Closed
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 11, 2019
@Jeffwan
Copy link
Contributor Author

Jeffwan commented Nov 13, 2019

/close this has been implemented

@Jeffwan Jeffwan closed this as completed Nov 13, 2019
@gjtempleton gjtempleton mentioned this issue Nov 20, 2019
Merged
@gjtempleton gjtempleton mentioned this issue Dec 30, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Jeffwan @k8s-ci-robot @fejta-bot