Vendored JobSet does not have Coordinator field in v0.8.0-

[avrittrohwer]

What happened:

Seen in kubernetes-sigs/jobset#701. When using JobSet and Kueue in the same cluster, Kueue needs to be at v0.9.0+ for the JobSet Coordinator field to not be nilled by the Kueue JobSet mutating webhook.

What you expected to happen:

Kueue mutating webhook does not remove valid JobSet fields.

How to reproduce it (as minimally and precisely as possible):

Install kueue v0.8.0 and JobSet v0.7.0 in a cluster. Create a JobSet with a non-nil Coordinator field. The Kueue mutating webhook will cause the JobSet to be created with a nil Coordinator field.

Anything else we need to know?:

Kueue v0.9.0 is the first version with a copy of jobset API with coordinator field: https://github.com/kubernetes-sigs/kueue/blob/release-0.9/vendor/sigs.k8s.io/jobset/api/jobset/v1alpha2/jobset_types.go

v0.8.0 does not have the field: https://github.com/kubernetes-sigs/kueue/blob/release-0.8/vendor/sigs.k8s.io/jobset/api/jobset/v1alpha2/jobset_types.go

Environment:

• Kubernetes version (use kubectl version): 1.31
• Kueue version (use git describe --tags --dirty --always): v0.8.0
• Cloud provider or hardware configuration:
• OS (e.g: cat /etc/os-release):
• Kernel (e.g. uname -a):
• Install tools:
• Others:

[mimowo]

0.8.3 should have the fix. ptal https://github.com/kubernetes-sigs/kueue/releases/tag/v0.8.3

[avrittrohwer]

0.8.3 should have the fix. ptal https://github.com/kubernetes-sigs/kueue/releases/tag/v0.8.3

https://github.com/kubernetes-sigs/kueue/blob/v0.8.3/vendor/sigs.k8s.io/jobset/api/jobset/v1alpha2/jobset_types.go#L65 does not have Coordinator field

[mimowo]

right, but if the root cause is that kueue webhook drops unknown field then this is fixed in 0.8.2 by a change to prevent dropping unknown fields; https://github.com/mimowo/kueue/blob/main/CHANGELOG%2FCHANGELOG-0.8.md: 'Prevent job webhooks from dropping fields for newer API fields when Kueue libraries are behind the latest released CRDs. (#3358, @mbobrovskyi)'

[avrittrohwer]

Ah I see

[avrittrohwer]

Updated kubernetes-sigs/jobset#702 with the fixed v0.8.3+ version

[avrittrohwer]

For any other fixed versions please update https://github.com/kubernetes-sigs/jobset/blob/main/site/content/en/docs/concepts/_index.md?plain=1#L204

[mimowo]

/close
I think this issue is no longer actionable. The new JobSet field can be used in 0.8.3+ and 0.9.0+.

[k8s-ci-robot]

@mimowo: Closing this issue.

In response to this:

/close
I think this issue is no longer actionable. The new JobSet field can be used in 0.8.3+ and 0.9.0+.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.