Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated cherry pick of #3132: Drop remove operations from webhook patches #3358

Conversation

mbobrovskyi
Copy link
Contributor

@mbobrovskyi mbobrovskyi commented Oct 29, 2024

Cherry pick of #3132 on release-0.8.

#3132: Drop remove operations from webhook patches

For details on the cherry pick process, see the cherry pick requests page.

Created manually due to #3132 (comment).

Summary:

  • Fixed go.mod conflicts.
  • Skip noop_webhook.go.
  • Skip deployment_webhook.go.

Fixes #3349

Prevent job webhooks from dropping fields for newer API fields when Kueue libraries are behind the latest released CRDs.

that could be caused by unkown fields in the go types

Change-Id: Iabc66880aef0227f60ec3deec9109cfb255fe2da
Change-Id: I4de1ebbe75a9220466c50381d0e708a1b6d23c8f
Change-Id: I232b1f2cd1a8a0c6b2f2fa7506da4d17d3e3ae55
@k8s-ci-robot k8s-ci-robot added this to the v0.8 milestone Oct 29, 2024
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 29, 2024
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 29, 2024
Copy link

netlify bot commented Oct 29, 2024

Deploy Preview for kubernetes-sigs-kueue ready!

Name Link
🔨 Latest commit adba0c9
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/6720cbd0e80b140008cece11
😎 Deploy Preview https://deploy-preview-3358--kubernetes-sigs-kueue.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mbobrovskyi
Copy link
Contributor Author

/cc @mimowo

@mimowo
Copy link
Contributor

mimowo commented Oct 29, 2024

/lgtm
/approve
/hold
for another look by @tenzen-y

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 29, 2024
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 29, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: e7ff450d07f49174400d20f90749ad6065c403b4

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 29, 2024
@mbobrovskyi
Copy link
Contributor Author

/assign @tenzen-y

Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.
/lgtm
/approvee

@tenzen-y
Copy link
Member

/approve
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 29, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mbobrovskyi, mimowo, tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 916dfde into kubernetes-sigs:release-0.8 Oct 29, 2024
16 checks passed
@mbobrovskyi mbobrovskyi deleted the automated-cherry-pick-of-#3132-upstream-release-0.8 branch October 29, 2024 16:07
@mimowo
Copy link
Contributor

mimowo commented Oct 30, 2024

/kind bug

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants