-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Coordinator concept #702
Conversation
Welcome @avrittrohwer! |
Hi @avrittrohwer. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
✅ Deploy Preview for kubernetes-sigs-jobset ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
/ok-to-test |
fieldPath: "metadata.labels['jobset.sigs.k8s.io/coordinator']" | ||
... | ||
``` | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For completeness, can we include an example of the resulting label/annotation that would be applied to jobs/pods, for the example spec above? So the user can verify correctness and understand what they should expect the stable network endpoint to look like.
i.e., jobset.sigs.k8s.io/coordinator=pytorch-leader-0-0.pytorch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added!
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: avrittrohwer, danielvegamyhre The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind documentation
What this PR does / why we need it:
Adds documentation for the Coordinator field.
Which issue(s) this PR fixes:
Fixes #701
Special notes for your reviewer:
Does this PR introduce a user-facing change?