Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use metadata to filter #406

Merged
merged 1 commit into from
Nov 9, 2018
Merged

Use metadata to filter #406

merged 1 commit into from
Nov 9, 2018

Conversation

Random-Liu
Copy link
Contributor

Fixes #403.

We should cherrypick this fix.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Random-Liu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 9, 2018
@k8s-ci-robot k8s-ci-robot requested a review from yujuhong November 9, 2018 02:22
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 9, 2018
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 9, 2018
@Random-Liu Random-Liu force-pushed the use-metadata-to-filter branch from 15a10ce to 333a6b4 Compare November 9, 2018 02:22
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 9, 2018
@Random-Liu Random-Liu force-pushed the use-metadata-to-filter branch from 333a6b4 to cd33519 Compare November 9, 2018 02:28
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 9, 2018
feiskyer
feiskyer reviewed Nov 9, 2018
View reviewed changes
Copy link
Member

@feiskyer feiskyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot merged commit 4370621 into kubernetes-sigs:master Nov 9, 2018
k8s-ci-robot added a commit that referenced this pull request Nov 10, 2018
@k8s-ci-robot
Merge pull request #408 from Random-Liu/cherrypick-#406-release-1.12
43f5e6e 
[release-1.12] Cherrypick #406
k8s-ci-robot added a commit that referenced this pull request Nov 10, 2018
@k8s-ci-robot
Merge pull request #409 from Random-Liu/cherrypick-#406-release-1.11
b6bd6d4 
[release-1.11] Cherrypick #406
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feiskyer feiskyer feiskyer left review comments

@yujuhong yujuhong Awaiting requested review from yujuhong

Assignees

@feiskyer feiskyer

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherrypick cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support "crictl pods --name filter" with Metadata name.
3 participants
@Random-Liu @k8s-ci-robot @feiskyer