Support "crictl pods --name filter" with Metadata name.

[rjaini]

if I use following pod config to create pod:
{
"metadata": {
"name": "linux-sandbox",
"namespace": "default",
"attempt": 1
},
"labels": {
"sandbox-platform": "linux/amd64"
}
}

crictl pods command return following output
POD ID CREATED STATE NAME NAMESPACE ATTEMPT
3e696d25f77a7 24 hours ago Ready linux-sandbox default 1

Now when I try to search the pod with above name
crictl pods --name linux-sandbox

I see no output. Ideally I should be able to get above pod.

But If I add below two labels with same value then things works.
io.kubernetes.pod.name
io.kubernetes.pod.namespace

Ideally I should also be able to search by metadata name.

[feiskyer]

@rjaini crictl pods --name supports regexp, could you try with that?

[jterry75]

@feiskyer - That's not what he is saying.

{
    "metadata": {
        "name": "linux-sandbox",
        "namespace": "default",
        "attempt": 1
    },
    "labels": {
        "sandbox-platform": "linux/amd64"
    }
}

crictrl pods --name linux-sandbox

Returns nothing.

--
But

{
    "metadata": {
        "name": "linux-sandbox",
        "namespace": "default",
        "attempt": 1
    },
    "labels": {
        "sandbox-platform": "linux/amd64",
        "io.kubernetes.pod.name": "test-name",
        "io.kubernetes.pod.namespace": "test-namespace"
    }
}

crictrl pods --name test-name

Returns the POD as expected.

--

The ask is that --name and --namespace support matching the metadata.Name and metadata.Namespace and not just the labels io.kubernetes.pod.name and io.kubernetes.pod.namespace.

[Random-Liu]

This makes sense to me. We don't need to use labels for metadata that already exists in the pod config.

[feiskyer]

@rjaini Oops, you are right.

[jterry75]

Thanks!

[rjaini]

Thanks.